Add test for checkInstallNetworkManager()

Signed-off-by: Federico Guerinoni <guerra@develer.com>

Author: Federico Guerinoni

handlers_stats.go

@@ -22,7 +22,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"os/exec"
-	"strings"
 
 	apt "github.com/arduino/go-apt-client"
 	"github.com/arduino/go-system-stats/disk"
@@ -70,25 +69,23 @@ func checkAndInstallNetworkManager() {
 	if err == nil {
 		return
 	}
-	if strings.Contains(err.Error(), "NetworkManager") {
-		// dpkg --configure -a for prevent block of installation
-		dpkgCmd := exec.Command("dpkg", "--configure", "-a")
-		if out, err := dpkgCmd.CombinedOutput(); err != nil {
-			fmt.Println("Failed to dpkg configure all:")
-			fmt.Println(string(out))
-		}
-		toInstall := &apt.Package{Name: "network-manager"}
-		if out, err := apt.Install(toInstall); err != nil {
-			fmt.Println("Failed to install network-manager:")
-			fmt.Println(string(out))
-			return
-		}
-		cmd := exec.Command("/etc/init.d/network-manager", "start")
-		if out, err := cmd.CombinedOutput(); err != nil {
-			fmt.Println("Failed to start network-manager:")
-			fmt.Println(string(out))
-		}
 
+	dpkgCmd := exec.Command("dpkg", "--configure", "-a")
+	if out, err := dpkgCmd.CombinedOutput(); err != nil {
+		fmt.Println("Failed to dpkg configure all:")
+		fmt.Println(string(out))
+	}
+
+	toInstall := &apt.Package{Name: "network-manager"}
+	if out, err := apt.Install(toInstall); err != nil {
+		fmt.Println("Failed to install network-manager:")
+		fmt.Println(string(out))
+		return
+	}
+	cmd := exec.Command("/etc/init.d/network-manager", "start")
+	if out, err := cmd.CombinedOutput(); err != nil {
+		fmt.Println("Failed to start network-manager:")
+		fmt.Println(string(out))
 	}
 }
 

install.go

@@ -35,7 +35,6 @@ import (
 	"net"
 	"net/http"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"strings"
 	"time"
@@ -68,15 +67,6 @@ func createConfigFolder() error {
 	return nil
 }
 
-func isDockerInstalled() (bool, error) {
-	_, err := exec.LookPath("docker")
-	if err == nil {
-		return true, nil
-	}
-
-	return false, nil
-}
-
 // Register creates the necessary certificates and configuration files
 func register(config Config, configFile, token string) {
 	// Request token

install_test.go

@@ -17,6 +17,7 @@ import (
 	"net/http"
 	"net/http/httptest"
 	"os"
+	"os/exec"
 	"path/filepath"
 	"strings"
 	"sync"
@@ -363,9 +364,37 @@ func connectTestClient(crtPath, keyPath string) (mqtt.Client, error) {
 	return mqttClient, nil
 }
 
+func isDockerInstalled() (bool, error) {
+	_, err := exec.LookPath("docker")
+	if err == nil {
+		return true, nil
+	}
+
+	return false, nil
+}
+
 func TestInstallDocker(t *testing.T) {
 	checkAndInstallDocker()
 	installed, err := isDockerInstalled()
 	assert.True(t, err == nil)
 	assert.True(t, installed)
 }
+
+func isNetManagerInstalled() bool {
+	cmd := exec.Command("bash", "-c", "dpkg --get-selections | grep network-manager")
+	out, _ := cmd.CombinedOutput()
+	return !strings.Contains(string(out), "deinstall") && len(out) != 0
+}
+
+func TestInstallNetworkManager(t *testing.T) {
+	assert.False(t, isNetManagerInstalled())
+	checkAndInstallNetworkManager()
+	defer func() {
+		c := exec.Command("bash", "-c", "apt-get remove -y network-manager")
+		_, err := c.CombinedOutput()
+		assert.True(t, err == nil)
+
+		assert.False(t, isNetManagerInstalled())
+	}()
+	assert.True(t, isNetManagerInstalled())
+}