Skip to content
This repository was archived by the owner on Mar 27, 2025. It is now read-only.

Commit 34103cb

Browse files
Do not make sketches and database world-readable
There is no real point in making this world-readable, so it is probably better to keep the data private.
1 parent df24875 commit 34103cb

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

handlers.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ func UploadCB(status *Status) mqtt.MessageHandler {
159159
}
160160

161161
// chmod it
162-
err = os.Chmod(name, 0744)
162+
err = os.Chmod(name, 0700)
163163
if err != nil {
164-
status.Error("/upload", errors.Wrapf(err, "chmod 744 %s", name))
164+
status.Error("/upload", errors.Wrapf(err, "chmod 700 %s", name))
165165
return
166166
}
167167

@@ -201,7 +201,7 @@ func GetSketchFolder() (string, error) {
201201
folder, err := osext.ExecutableFolder()
202202
folder = filepath.Join(folder, "sketches")
203203
if _, err := os.Stat(folder); os.IsNotExist(err) {
204-
err = os.Mkdir(folder, 0755)
204+
err = os.Mkdir(folder, 0700)
205205
}
206206
return folder, err
207207
}
@@ -211,7 +211,7 @@ func GetSketchDBFolder() (string, error) {
211211
folder, err := GetSketchFolder()
212212
folder = filepath.Join(folder, "db")
213213
if _, err := os.Stat(folder); os.IsNotExist(err) {
214-
err = os.Mkdir(folder, 0755)
214+
err = os.Mkdir(folder, 0700)
215215
}
216216
return folder, err
217217
}
@@ -244,7 +244,7 @@ func InsertSketchInDB(name string, id string) {
244244
}
245245
c = append(c, SketchBinding{ID: id, Name: name})
246246
data, _ := json.Marshal(c)
247-
ioutil.WriteFile(db, data, 0644)
247+
ioutil.WriteFile(db, data, 0600)
248248
}
249249

250250
func GetSketchIDFromDB(name string) (string, error) {

main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ func addWatcherForManuallyAddedSketches(folderOrigin, folderDest string, status
278278
break
279279
}
280280
}
281-
os.Chmod(filename, 0755)
281+
os.Chmod(filename, 0700)
282282
log.Println("Moving new sketch to sketches folder")
283283
fileInfo, err := os.Stat(filename)
284284
if err != nil {

0 commit comments

Comments
 (0)