Skip to content

compile --show-properties now correctly output the result in text and JSON format #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 17, 2023
Merged

compile --show-properties now correctly output the result in text and JSON format #2035

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73bb0cf
Added function to create buffering streams
cmaglie Jan 17, 2023
cf38a96
Moved the direct output of build properties to commands.Compile
cmaglie Jan 17, 2023
23f95f3
BuildProperties are now returned as part of Compile response
cmaglie Jan 17, 2023
1406aa1
Build properties are now displayed alone if running in text mode
cmaglie Jan 17, 2023
33723af
Fixed wrong error report
cmaglie Jan 17, 2023
39e5515
Added integration test
cmaglie Jan 17, 2023
67eec02
Small improvement on result output
cmaglie Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed wrong error report
  • Loading branch information
@cmaglie
cmaglie committed Jan 17, 2023
commit 33723af8cb82b4a5da8f6de9b43609ddcb075aab
4 changes: 2 additions & 2 deletions commands/compile/compile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ func Compile(ctx context.Context, req *rpc.CompileRequest, outStream, errStream
// Just get build properties and exit
compileErr := builder.RunParseHardware(builderCtx)
if compileErr != nil {
compileErr = &arduino.CompileFailedError{Message: err.Error()}
compileErr = &arduino.CompileFailedError{Message: compileErr.Error()}
}
return r, compileErr
}
Expand All @@ -211,7 +211,7 @@ func Compile(ctx context.Context, req *rpc.CompileRequest, outStream, errStream
// Just output preprocessed source code and exit
compileErr := builder.RunPreprocess(builderCtx)
if compileErr != nil {
compileErr = &arduino.CompileFailedError{Message: err.Error()}
compileErr = &arduino.CompileFailedError{Message: compileErr.Error()}
}
return r, compileErr
}
Expand Down