Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arduino/arduino-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 686ff3eeae01f031509b238f2da2ea222c3d9f14
Choose a base ref
...
head repository: arduino/arduino-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 08d25b5d382547f5bcca3eea32ddab99a9008ce5
Choose a head ref
  • 14 commits
  • 10 files changed
  • 4 contributors

Commits on Oct 11, 2022

  1. [skip-changelog] Migrate tests from test_board.py to board_test.go (

    #1847)
    
    * Migrated TestBoardList from test_board.py to board_test.go
    
    * Migrated TestBoardListWithInvalidDiscovery from test_board.py to board_test.go
    
    * Migrated TestBoardListall from test_board.py to board_test.go
    
    * Migrated TestBoardListallWithManuallyInstalledPlatform from test_board.py to board_test.go
    
    * Migrated TestBoardDetails from test_board.py to board_test.go
    
    * Migrated TestBoardDetailsNoFlags from test_board.py to board_test.go
    
    * Migrated TestBoardDetailsListProgrammersWithoutFlags from test_board.py to board_test.go
    
    * Migrated TestBoardDetailsListProgrammersFlags from test_board.py to board_test.go
    
    * Migrated TestBoardSearch from test_board.py to board_test.go
    
    * Migrated TestBoardAttachWithoutSketchJson from test_board.py to board_test.go
    
    * Migrated TestBoardSearchWithOutdatedCore to board_test.go and deleted test_board.py
    MatteoPologruto authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    fb9d4a8 View commit details
    Browse the repository at this point in the history
  2. [skip changelog] Move upload of coverage data to dedicated job in tes…

    …t workflow (#1915)
    
    * Move upload of coverage data to dedicated job in test workflow
    
    The code coverage data generated by running the unit tests in the "Test Go" GitHub Actions workflow is uploaded to
    Codecov.
    
    This upload is prone to occasional transient failures. With the previous workflow configuration this caused a failure of
    the Linux test run job. Contributors would need to review the logs to understand that these failures were not caused by
    a test failing. The failure also causes the ongoing jobs that run the tests on other operating systems to be immediately
    canceled, meaning their full test results are not available. The entire test suite must be reran just to attempt the
    upload again.
    
    Moving the upload to a dedicated workflow job makes it faster and easier for contributors to interpret the cause of a
    test failure. It also allows the test suite to complete for all operating systems, making their results immediately
    available to the contributor even when the coverage data upload fails. The coverage upload job can be reran, making
    recovery from a transient failure more efficient.
    
    * Use a single step to upload coverage data in "Test Go" workflow
    
    The code coverage data generated by running the unit tests in the "Test Go" GitHub Actions workflow is uploaded to
    Codecov. Arduino CLI's unit tests are split into two collections: those covering the modernized part of the codebase,
    and those covering the "legacy" code inherited from arduino-builder. A separate code coverage data file is produced for
    each of these collections.
    
    The `codecov/codecov-action` GitHub Actions action is used to perform this upload. Previously, a separate step was used
    for the upload of each of the code coverage files. The action provides the capability to specify multiple files for
    upload in a comma-separated list. This approach will make the workflow more efficient and reliable.
    per1234 authored Oct 11, 2022
    Configuration menu
    Copy the full SHA
    08d746d View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Configuration menu
    Copy the full SHA
    589cbcc View commit details
    Browse the repository at this point in the history
  2. [skip-changelog] Fix copySketch testsuite function (#1918)

    The original copy sketch function written in conftest.py copies sketches into the testsuite's working directory. Changing the copy sketch function present in the golang testsuite to match the original one,
    should prevent errors that could occur while migrating tests.
    MatteoPologruto authored Oct 12, 2022
    Configuration menu
    Copy the full SHA
    12c6c32 View commit details
    Browse the repository at this point in the history
  3. Migrate TestCompileSketchWithPdeExtension from test_compile_part_3.py…

    … to compile_part_3_test.go
    MatteoPologruto committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    a0b0f6b View commit details
    Browse the repository at this point in the history
  4. Migrate TestCompileSketchWithMultipleMainFiles from test_compile_part…

    …_3.py to compile_part_3_test.go
    MatteoPologruto committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    4589c49 View commit details
    Browse the repository at this point in the history
  5. Migrate TestCompileSketchCaseMismatchFails from test_compile_part_3.p…

    …y to compile_part_3_test.go
    
    A new function that sets the working directory to a specific path has been added in order to run all the tests as intended.
    MatteoPologruto committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    9070fe7 View commit details
    Browse the repository at this point in the history
  6. Migrate TestCompileWithOnlyCompilationDatabaseFlag from test_compile_…

    …part_3.py to compile_part_3_test.go
    MatteoPologruto committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    c6fb37b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c966e57 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    174e3d2 View commit details
    Browse the repository at this point in the history
  9. Migrate TestCompileManuallyInstalledPlatform from test_compile_part_3…

    ….py to compile_part_3_test.go
    MatteoPologruto committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    66cecca View commit details
    Browse the repository at this point in the history
  10. Migrate TestCompileManuallyInstalledPlatformUsingPlatformLocalTxt fro…

    …m test_compile_part_3.py to compile_part_3_test.go
    MatteoPologruto committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    0801651 View commit details
    Browse the repository at this point in the history
  11. Migrate TestCompileWithFullyPrecompiledLibrary to compile_part_3_test…

    ….go and delete test_compile_part_3.py
    MatteoPologruto committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    380daf5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    08d25b5 View commit details
    Browse the repository at this point in the history
Loading