Fixed some linter warnings

Author: cmaglie

arduino/cores/packagemanager/loader.go

@@ -589,6 +589,8 @@ func convertUploadToolsToPluggableDiscovery(props *properties.Map) {
 	props.Merge(propsToAdd)
 }
 
+// LoadToolsFromPackageDir loads a set of tools from the given toolsPath. The tools will be loaded
+// in the given *Package.
 func (pm *PackageManager) LoadToolsFromPackageDir(targetPackage *cores.Package, toolsPath *paths.Path) []error {
 	pm.Log.Infof("Loading tools from dir: %s", toolsPath)
 

arduino/sketch/profiles.go

@@ -134,14 +134,15 @@ func parseNameAndVersion(in string) (string, string, bool) {
 	return split[0][1], split[0][2], true
 }
 
+// UnmarshalYAML decodes a ProfilePlatformReference from YAML source.
 func (p *ProfilePlatformReference) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	var data map[string]string
 	if err := unmarshal(&data); err != nil {
 		return err
 	}
-	if platformId, ok := data["platform"]; !ok {
+	if platformID, ok := data["platform"]; !ok {
 		return fmt.Errorf(tr("missing 'platform' directive"))
-	} else if platformId, platformVersion, ok := parseNameAndVersion(platformId); !ok {
+	} else if platformId, platformVersion, ok := parseNameAndVersion(platformID); !ok {
 		return fmt.Errorf(tr("invalid 'platform' directive"))
 	} else if c, err := semver.Parse(platformVersion); err != nil {
 		return fmt.Errorf("%s: %w", tr("error parsing version constraints"), err)
@@ -154,11 +155,11 @@ func (p *ProfilePlatformReference) UnmarshalYAML(unmarshal func(interface{}) err
 	}
 
 	if rawIndexURL, ok := data["platform_index_url"]; ok {
-		if indexURL, err := url.Parse(rawIndexURL); err != nil {
+		indexURL, err := url.Parse(rawIndexURL)
+		if err != nil {
 			return fmt.Errorf("%s: %w", tr("invlid platform index URL:"), err)
-		} else {
-			p.PlatformIndexURL = indexURL
 		}
+		p.PlatformIndexURL = indexURL
 	}
 	return nil
 }
@@ -169,6 +170,7 @@ type ProfileLibraryReference struct {
 	Version *semver.Version
 }
 
+// UnmarshalYAML decodes a ProfileLibraryReference from YAML source.
 func (l *ProfileLibraryReference) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	var data string
 	if err := unmarshal(&data); err != nil {

cli/instance/instance.go

@@ -41,6 +41,9 @@ func CreateAndInit() *rpc.Instance {
 	return inst
 }
 
+// CreateAndInitWithProfile return a new initialized instance using the given profile in the give sketch.
+// If Create fails the CLI prints an error and exits since to execute further operations a valid Instance is mandatory.
+// If Init returns errors they're printed only.
 func CreateAndInitWithProfile(profileName string, sketchPath *paths.Path) (*rpc.Instance, *rpc.Profile) {
 	instance, err := Create()
 	if err != nil {
@@ -73,6 +76,9 @@ func Init(instance *rpc.Instance) []error {
 	return errs
 }
 
+// InitWithProfile initializes instance by loading libraries and platforms specified in the given profile of the given sketch.
+// In case of loading failures return a list of errors for each platform or library that we failed to load.
+// Required Package and library indexes files are automatically downloaded.
 func InitWithProfile(instance *rpc.Instance, profileName string, sketchPath *paths.Path) (*rpc.Profile, []error) {
 	errs := []error{}