Fix issue when using Init to rescan installed core on already initialized instance

Author: silvanocerza

arduino/cores/packagemanager/package_manager.go

@@ -58,6 +58,11 @@ func NewPackageManager(indexDir, packagesDir, downloadDir, tempDir *paths.Path)
 	}
 }
 
+func (pm *PackageManager) Clear() {
+	pm.Packages = cores.NewPackages()
+	pm.CustomGlobalProperties = properties.NewMap()
+}
+
 // FindPlatformReleaseProvidingBoardsWithVidPid FIXMEDOC
 func (pm *PackageManager) FindPlatformReleaseProvidingBoardsWithVidPid(vid, pid string) []*cores.PlatformRelease {
 	res := []*cores.PlatformRelease{}

arduino/cores/packagemanager/package_manager_test.go

@@ -320,3 +320,20 @@ func TestIdentifyBoard(t *testing.T) {
 	require.Equal(t, "[test:avr:e]", fmt.Sprintf("%v", identify("0xAB00", "0xcd00")))
 	require.Equal(t, "[test:avr:e]", fmt.Sprintf("%v", identify("0xab00", "0xCD00")))
 }
+
+func TestPackageManagerClear(t *testing.T) {
+	// Create a PackageManager and load the harware
+	packageManager := packagemanager.NewPackageManager(customHardware, customHardware, customHardware, customHardware)
+	packageManager.LoadHardwareFromDirectory(customHardware)
+
+	// Creates another PackageManager but don't load the hardware
+	emptyPackageManager := packagemanager.NewPackageManager(customHardware, customHardware, customHardware, customHardware)
+
+	// Verifies they're not equal
+	require.NotEqual(t, &packageManager, &emptyPackageManager)
+
+	// Clear the first PackageManager that contains loaded hardware
+	packageManager.Clear()
+	// Verifies both PackageManagers are now equal
+	require.Equal(t, &packageManager, &emptyPackageManager)
+}

commands/instances.go

@@ -175,6 +175,13 @@ func Init(req *rpc.InitRequest, responseCallback func(r *rpc.InitResponse)) *sta
 		return status.Newf(codes.InvalidArgument, "Invalid instance ID")
 	}
 
+	// We need to clear the PackageManager currently in use by this instance
+	// in case this is not the first Init on this instances, that might happen
+	// after reinitializing an instance after installing or uninstalling a core.
+	// If this is not done the information of the uninstall core is kept in memory,
+	// even if it should not.
+	instance.PackageManager.Clear()
+
 	// Load Platforms
 	urls := []string{globals.DefaultIndexURL}
 	urls = append(urls, configuration.Settings.GetStringSlice("board_manager.additional_urls")...)