Migrate TestCoreListWithInstalledJson from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -534,3 +534,51 @@ func TestCoreInstallRemovesUnusedTools(t *testing.T) {
 	// Verifies tool is uninstalled since it's not used by newer core version
 	require.NoDirExists(t, toolPath.String())
 }
+
+func TestCoreListWithInstalledJson(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Install core
+	url := "https://adafruit.github.io/arduino-board-index/package_adafruit_index.json"
+	_, _, err = cli.Run("core", "update-index", "--additional-urls="+url)
+	require.NoError(t, err)
+	_, _, err = cli.Run("core", "install", "adafruit:avr@1.4.13", "--additional-urls="+url)
+	require.NoError(t, err)
+
+	// Verifies installed core is correctly found and name is set
+	stdout, _, err := cli.Run("core", "list", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Len(t, stdout, 1)
+	requirejson.Contains(t, stdout, `[
+		{
+			"id": "adafruit:avr",
+			"name": "Adafruit AVR Boards"
+		}
+	]`)
+
+	// Deletes installed.json file, this file stores information about the core,
+	// that is used mostly when removing package indexes and their cores are still installed;
+	// this way we don't lose much information about it.
+	// It might happen that the user has old cores installed before the addition of
+	// the installed.json file so we need to handle those cases.
+	installedJson := cli.DataDir().Join("packages", "adafruit", "hardware", "avr", "1.4.13", "installed.json")
+	require.NoError(t, installedJson.Remove())
+
+	// Verifies installed core is still found and name is set
+	stdout, _, err = cli.Run("core", "list", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Len(t, stdout, 1)
+	// Name for this core changes since if there's installed.json file we read it from
+	// platform.txt, turns out that this core has different names used in different files
+	// thus the change.
+	requirejson.Contains(t, stdout, `[
+		{
+			"id": "adafruit:avr",
+			"name": "Adafruit Boards"
+		}
+	]`)
+}

test/test_core.py

@@ -68,44 +68,6 @@ def ordered(obj):
     assert ordered(installed_json) == ordered(expected_installed_json)
 
 
-def test_core_list_with_installed_json(run_command, data_dir):
-    assert run_command(["update"])
-
-    # Install core
-    url = "https://adafruit.github.io/arduino-board-index/package_adafruit_index.json"
-    assert run_command(["core", "update-index", f"--additional-urls={url}"])
-    assert run_command(["core", "install", "adafruit:avr@1.4.13", f"--additional-urls={url}"])
-
-    # Verifies installed core is correctly found and name is set
-    res = run_command(["core", "list", "--format", "json"])
-    assert res.ok
-    cores = json.loads(res.stdout)
-    mapped = {core["id"]: core for core in cores}
-    assert len(mapped) == 1
-    assert "adafruit:avr" in mapped
-    assert mapped["adafruit:avr"]["name"] == "Adafruit AVR Boards"
-
-    # Deletes installed.json file, this file stores information about the core,
-    # that is used mostly when removing package indexes and their cores are still installed;
-    # this way we don't lose much information about it.
-    # It might happen that the user has old cores installed before the addition of
-    # the installed.json file so we need to handle those cases.
-    installed_json = Path(data_dir, "packages", "adafruit", "hardware", "avr", "1.4.13", "installed.json")
-    installed_json.unlink()
-
-    # Verifies installed core is still found and name is set
-    res = run_command(["core", "list", "--format", "json"])
-    assert res.ok
-    cores = json.loads(res.stdout)
-    mapped = {core["id"]: core for core in cores}
-    assert len(mapped) == 1
-    assert "adafruit:avr" in mapped
-    # Name for this core changes since if there's installed.json file we read it from
-    # platform.txt, turns out that this core has different names used in different files
-    # thus the change.
-    assert mapped["adafruit:avr"]["name"] == "Adafruit Boards"
-
-
 def test_core_search_update_index_delay(run_command, data_dir):
     assert run_command(["update"])