adding separate debug info (info + warn -> stdout, errors -> stderr) for all comands.

Author: saniales

cmd/arduino.go

@@ -120,6 +120,10 @@ arduino login --user myUser --password # Asks to write the password inside the c
 
 var testing = false
 
+// ErrLogrus represents the logrus instance, which has the role to
+// log all non info messages.
+var ErrLogrus = logrus.New()
+
 func init() {
 	versions[ArduinoCmd.Name()] = ArduinoVersion
 	InitFlags()
@@ -255,9 +259,10 @@ func IgnoreConfigs() {
 func arduinoPreRun(cmd *cobra.Command, args []string) {
 	// Reset logrus if debug flag changed
 	if !GlobalFlags.Debug { // discard logrus output if no debug
-		logrus.SetOutput(ioutil.Discard)
+		logrus.SetOutput(ioutil.Discard) // for standard logger
+		ErrLogrus.Out = ioutil.Discard   // for error logger
 	} else { // else print on stderr
-		logrus.SetOutput(os.Stderr)
+		ErrLogrus.Out = os.Stderr
 	}
 	InitConfigs()
 
@@ -359,7 +364,7 @@ func initViper() {
 
 	defHome, err := common.GetDefaultArduinoHomeFolder()
 	if err != nil {
-		logrus.WithError(err).Warn("Cannot get default Arduino Home")
+		ErrLogrus.WithError(err).Warn("Cannot get default Arduino Home")
 	}
 	defArduinoData, err := common.GetDefaultArduinoFolder()
 	if err != nil {
@@ -373,7 +378,7 @@ func initViper() {
 	logrus.Info("Reading configuration for viper")
 	err = viper.ReadInConfig()
 	if err != nil {
-		logrus.WithError(err).Error("Cannot read configuration file in any of the default folders")
+		ErrLogrus.WithError(err).Error("Cannot read configuration file in any of the default folders")
 		formatter.PrintErrorMessage("Cannot read configuration file in any of the default folders")
 		os.Exit(errNoConfigFile)
 	}
@@ -392,7 +397,7 @@ func initViper() {
 	if viper.GetString("proxy.type") == "manual" {
 		hostname := viper.GetString("proxy.hostname")
 		if hostname == "" {
-			logrus.Error("With manual proxy configuration, hostname is required.")
+			ErrLogrus.Error("With manual proxy configuration, hostname is required.")
 			formatter.PrintErrorMessage("With manual proxy configuration, hostname is required.")
 			os.Exit(errCoreConfig)
 		}
@@ -419,7 +424,7 @@ func executeLoginCommand(cmd *cobra.Command, args []string) {
 	passwordEmpty := arduinoLoginFlags.Password == ""
 	isTextMode := formatter.IsCurrentFormat("text")
 	if !isTextMode && (userEmpty || passwordEmpty) {
-		logrus.Error("User and password must be specified outside of text format")
+		ErrLogrus.Error("User and password must be specified outside of text format")
 		formatter.PrintErrorMessage("User and password must be specified outside of text format")
 		return
 	}
@@ -434,7 +439,7 @@ func executeLoginCommand(cmd *cobra.Command, args []string) {
 		fmt.Print("Password: ")
 		pass, err := terminal.ReadPassword(syscall.Stdin)
 		if err != nil {
-			logrus.WithError(err).Error("Cannot read password, login aborted")
+			ErrLogrus.WithError(err).Error("Cannot read password, login aborted")
 			formatter.PrintErrorMessage("Cannot read password, login aborted")
 			return
 		}

cmd/arduino_config.go

@@ -74,7 +74,7 @@ func executeConfigInitCommand(cmd *cobra.Command, args []string) {
 
 	if !arduinoConfigInitFlags.Default {
 		if !formatter.IsCurrentFormat("text") {
-			logrus.Error("The interactive mode is supported only in text mode")
+			ErrLogrus.Error("The interactive mode is supported only in text mode")
 			formatter.PrintErrorMessage("The interactive mode is supported only in text mode")
 			os.Exit(errBadCall)
 		}

cmd/arduino_core.go

@@ -167,7 +167,7 @@ func executeCoreDownloadCommand(cmd *cobra.Command, args []string) {
 	logrus.Info("Executing `arduino core download`")
 
 	if len(args) < 1 {
-		logrus.Error("No core specified for download command, exiting")
+		ErrLogrus.Error("No core specified for download command, exiting")
 		formatter.PrintErrorMessage("No core specified for download command")
 		os.Exit(errBadCall)
 	}
@@ -209,7 +209,7 @@ func executeCoreInstallCommand(cmd *cobra.Command, args []string) {
 	logrus.Info("Executing `arduino core download`")
 
 	if len(args) < 1 {
-		logrus.Error("No core specified for download command, exiting")
+		ErrLogrus.Error("No core specified for download command, exiting")
 		formatter.PrintErrorMessage("No core specified for download command")
 		os.Exit(errBadCall)
 	}

cmd/arduino_sketch.go

@@ -75,17 +75,17 @@ var arduinoSketchSyncCmd = &cobra.Command{
 
 func executeSketchCommand(cmd *cobra.Command, args []string) {
 	logrus.Info("Executing `arduino sketch`")
-	logrus.Error("No subcommand specified, showing help message")
+	ErrLogrus.Error("No subcommand specified, showing help message")
 	formatter.PrintErrorMessage("No subcommand specified")
 	cmd.Help()
-	logrus.Error("Bad Call Exit")
+	ErrLogrus.Error("Bad Call Exit")
 	os.Exit(errBadCall)
 }
 
 func executeSketchSyncCommand(cmd *cobra.Command, args []string) {
 	logrus.Info("Executing `arduino sketch sync`")
 	if len(args) > 0 {
-		logrus.Error("No arguments are accepted for this command")
+		ErrLogrus.Error("No arguments are accepted for this command")
 		formatter.PrintErrorMessage("No arguments are accepted")
 		os.Exit(errBadCall)
 	}
@@ -104,7 +104,7 @@ func executeSketchSyncCommand(cmd *cobra.Command, args []string) {
 
 	if priority == "ask-once" {
 		if !isTextMode {
-			logrus.Error("ask mode for this command is only supported using text format")
+			ErrLogrus.Error("ask mode for this command is only supported using text format")
 			formatter.PrintErrorMessage("ask mode for this command is only supported using text format")
 			os.Exit(errBadCall)
 		}

task/concurrency.go

@@ -100,7 +100,6 @@ func ExecuteParallelFromMap(taskMap map[string]Wrapper) map[string]Result {
 	close(results)
 	mapResult := make(map[string]Result, len(results))
 	for result := range results {
-		//logrus.Errorf("results : %v %v\n", result.Key, result.Result)
 		mapResult[result.Key] = result.Result
 	}
 	return mapResult