Migrate TestSketchArchiveWithPdeMainFile from test_sketch.py to sketch_test.go

Author: MatteoPologruto

internal/integrationtest/sketch/sketch_test.go

@@ -827,3 +827,25 @@ func TestSketchArchiveAbsoluteSketchPathWithAbsoluteZipPathAndNameWithExtensionW
 	defer require.NoError(t, archive.Close())
 	verifyZipContainsSketchIncludingBuildDir(t, archive.File)
 }
+
+func TestSketchArchiveWithPdeMainFile(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	sketchName := "sketch_pde_main_file"
+	sketchDir := cli.CopySketch(sketchName)
+	sketchFile := sketchDir.Join(sketchName + ".pde")
+	relPath, err := sketchFile.RelFrom(sketchDir)
+	require.NoError(t, err)
+	cli.SetWorkingDir(sketchDir)
+	_, stderr, err := cli.Run("sketch", "archive")
+	require.NoError(t, err)
+	require.Contains(t, string(stderr), "Sketches with .pde extension are deprecated, please rename the following files to .ino")
+	require.Contains(t, string(stderr), relPath.String())
+	cli.SetWorkingDir(env.RootDir())
+
+	archive, err := zip.OpenReader(cli.WorkingDir().Join(sketchName + ".zip").String())
+	require.NoError(t, err)
+	defer require.NoError(t, archive.Close())
+	require.Contains(t, archive.File[0].Name, paths.New(sketchName, sketchName+".pde").String())
+}

test/testdata/sketch_pde_main_file/sketch_pde_main_file.pde renamed to internal/integrationtest/testdata/sketch_pde_main_file/sketch_pde_main_file.pde

@@ -48,23 +48,6 @@ def verify_zip_contains_sketch_including_build_dir(files):
     assert "sketch_simple/build/arduino.avr.uno/sketch_simple.ino.with_bootloader.hex" in files
 
 
-def test_sketch_archive_with_pde_main_file(run_command, copy_sketch, working_dir):
-    sketch_name = "sketch_pde_main_file"
-    sketch_dir = copy_sketch(sketch_name)
-    sketch_file = Path(sketch_dir, f"{sketch_name}.pde")
-    res = run_command(["sketch", "archive"], sketch_dir)
-    assert res.ok
-    assert "Sketches with .pde extension are deprecated, please rename the following files to .ino" in res.stderr
-    assert str(sketch_file.relative_to(sketch_dir)) in res.stderr
-
-    archive = zipfile.ZipFile(f"{working_dir}/{sketch_name}.zip")
-    archive_files = archive.namelist()
-
-    assert f"{sketch_name}/{sketch_name}.pde" in archive_files
-
-    archive.close()
-
-
 def test_sketch_archive_with_multiple_main_files(run_command, copy_sketch, working_dir):
     sketch_name = "sketch_multiple_main_files"
     sketch_dir = copy_sketch(sketch_name)