Migrate TestCoreDownloadMultiplePlatforms from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -833,6 +833,46 @@ func TestCoreListPlatformWithoutPlatformTxt(t *testing.T) {
 	requirejson.Query(t, stdout, ".[] | .name", "\"some-packager-some-arch\"")
 }
 
+func TestCoreDownloadMultiplePlatforms(t *testing.T) {
+	if runtime.GOOS == "windows" || runtime.GOOS == "darwin" {
+		t.Skip("macOS by default is case insensitive https://github.com/actions/virtual-environments/issues/865 ",
+			"Windows too is case insensitive",
+			"https://stackoverflow.com/questions/7199039/file-paths-in-windows-environment-not-case-sensitive")
+	}
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Verifies no core is installed
+	stdout, _, err := cli.Run("core", "list", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Len(t, stdout, 0)
+
+	// Simulates creation of two new cores in the sketchbook hardware folder
+	wd, _ := paths.Getwd()
+	testBoardsTxt := wd.Parent().Join("testdata", "boards.local.txt")
+	boardsTxt := cli.DataDir().Join("packages", "PACKAGER", "hardware", "ARCH", "1.0.0", "boards.txt")
+	require.NoError(t, boardsTxt.Parent().MkdirAll())
+	require.NoError(t, testBoardsTxt.CopyTo(boardsTxt))
+
+	boardsTxt1 := cli.DataDir().Join("packages", "packager", "hardware", "arch", "1.0.0", "boards.txt")
+	require.NoError(t, boardsTxt1.Parent().MkdirAll())
+	require.NoError(t, testBoardsTxt.CopyTo(boardsTxt1))
+
+	// Verifies the two cores are detected
+	stdout, _, err = cli.Run("core", "list", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Len(t, stdout, 2)
+
+	// Try to do an operation on the fake cores.
+	// The cli should not allow it since optimizing the casing results in finding two cores
+	_, stderr, err := cli.Run("core", "upgrade", "Packager:Arch")
+	require.Error(t, err)
+	require.Contains(t, string(stderr), "Invalid argument passed: Found 2 platform for reference")
+}
+
 func TestCoreWithMissingCustomBoardOptionsIsLoaded(t *testing.T) {
 	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
 	defer env.CleanUp()

test/test_core.py

@@ -12,18 +12,9 @@
 # otherwise use the software for commercial activities involving the Arduino
 # software without disclosing the source code of your own applications. To purchase
 # a commercial license, send an email to license@arduino.cc.
-import os
-import datetime
-import shutil
-import time
-import platform
-import pytest
+
 import simplejson as json
-import tempfile
-import hashlib
-from git import Repo
 from pathlib import Path
-import semver
 
 
 def test_core_install_creates_installed_json(run_command, data_dir):
@@ -45,43 +36,3 @@ def ordered(obj):
             return obj
 
     assert ordered(installed_json) == ordered(expected_installed_json)
-
-
-@pytest.mark.skipif(
-    platform.system() in ["Darwin", "Windows"],
-    reason="macOS by default is case insensitive https://github.com/actions/virtual-environments/issues/865 "
-    + "Windows too is case insensitive"
-    + "https://stackoverflow.com/questions/7199039/file-paths-in-windows-environment-not-case-sensitive",
-)
-def test_core_download_multiple_platforms(run_command, data_dir):
-    assert run_command(["update"])
-
-    # Verifies no core is installed
-    res = run_command(["core", "list", "--format", "json"])
-    assert res.ok
-    cores = json.loads(res.stdout)
-    assert len(cores) == 0
-
-    # Simulates creation of two new cores in the sketchbook hardware folder
-    test_boards_txt = Path(__file__).parent / "testdata" / "boards.local.txt"
-    boards_txt = Path(data_dir, "packages", "PACKAGER", "hardware", "ARCH", "1.0.0", "boards.txt")
-    boards_txt.parent.mkdir(parents=True, exist_ok=True)
-    boards_txt.touch()
-    assert boards_txt.write_bytes(test_boards_txt.read_bytes())
-
-    boards_txt1 = Path(data_dir, "packages", "packager", "hardware", "arch", "1.0.0", "boards.txt")
-    boards_txt1.parent.mkdir(parents=True, exist_ok=True)
-    boards_txt1.touch()
-    assert boards_txt1.write_bytes(test_boards_txt.read_bytes())
-
-    # Verifies the two cores are detected
-    res = run_command(["core", "list", "--format", "json"])
-    assert res.ok
-    cores = json.loads(res.stdout)
-    assert len(cores) == 2
-
-    # Try to do an operation on the fake cores.
-    # The cli should not allow it since optimizing the casing results in finding two cores
-    res = run_command(["core", "upgrade", "Packager:Arch"])
-    assert res.failed
-    assert "Invalid argument passed: Found 2 platform for reference" in res.stderr