Migrate TestCoreUpdateIndexUrlNotFound from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -188,3 +188,19 @@ func TestCoreSearchNoArgs(t *testing.T) {
 	requirejson.Query(t, stdout, " .[] | select(.name == \"test_core\") | . != \"\"", "true")
 	requirejson.Query(t, stdout, "length", fmt.Sprint(numPlatforms))
 }
+
+func TestCoreUpdateIndexUrlNotFound(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Brings up a local server to fake a failure
+	url := env.HTTPServeFileError(8000, paths.New("test_index.json"), 404)
+
+	stdout, stderr, err := cli.Run("core", "update-index", "--additional-urls="+url.String())
+	require.Error(t, err)
+	require.Contains(t, string(stdout), "Downloading index: test_index.json Server responded with: 404 Not Found")
+	require.Contains(t, string(stderr), "Some indexes could not be updated.")
+}

test/test_core.py

@@ -26,21 +26,6 @@
 import semver
 
 
-def test_core_updateindex_url_not_found(run_command, httpserver):
-    assert run_command(["core", "update-index"])
-
-    # Brings up a local server to fake a failure
-    httpserver.expect_request("/test_index.json").respond_with_data(status=404)
-    url = httpserver.url_for("/test_index.json")
-
-    result = run_command(["core", "update-index", f"--additional-urls={url}"])
-    assert result.failed
-    linesout = [l.strip() for l in result.stdout.splitlines()]
-    assert "Downloading index: test_index.json Server responded with: 404 NOT FOUND" in linesout
-    lineserr = [l.strip() for l in result.stderr.splitlines()]
-    assert "Some indexes could not be updated." in lineserr
-
-
 def test_core_updateindex_internal_server_error(run_command, httpserver):
     assert run_command(["core", "update-index"])