refactor StoreBuildOptionsMap in a function

Author: alessio-perugini

legacy/builder/container_build_options.go

@@ -39,11 +39,7 @@ func (s *ContainerBuildOptions) Run(ctx *types.Context) error {
 	}
 	ctx.BuildOptionsJsonPrevious = buildOptionsJsonPrevious
 
-	commands := []types.Command{
-		&WipeoutBuildPathIfBuildOptionsChanged{},
-		&StoreBuildOptionsMap{},
-	}
-
+	commands := []types.Command{&WipeoutBuildPathIfBuildOptionsChanged{}}
 	for _, command := range commands {
 		PrintRingNameIfDebug(ctx, command)
 		err := command.Run(ctx)
@@ -52,5 +48,5 @@ func (s *ContainerBuildOptions) Run(ctx *types.Context) error {
 		}
 	}
 
-	return nil
+	return StoreBuildOptionsMap(ctx.BuildPath, ctx.BuildOptionsJson)
 }

legacy/builder/store_build_options_map.go

@@ -17,12 +17,9 @@ package builder
 
 import (
 	"github.com/arduino/arduino-cli/legacy/builder/constants"
-	"github.com/arduino/arduino-cli/legacy/builder/types"
+	"github.com/arduino/go-paths-helper"
 )
 
-type StoreBuildOptionsMap struct{}
-
-func (s *StoreBuildOptionsMap) Run(ctx *types.Context) error {
-	ctx.BuildPath.Join(constants.BUILD_OPTIONS_FILE).WriteFile([]byte(ctx.BuildOptionsJson))
-	return nil
+func StoreBuildOptionsMap(buildPath *paths.Path, buildOptionsJson string) error {
+	return buildPath.Join(constants.BUILD_OPTIONS_FILE).WriteFile([]byte(buildOptionsJson))
 }

legacy/builder/test/store_build_options_map_test.go

@@ -51,11 +51,8 @@ func TestStoreBuildOptionsMap(t *testing.T) {
 	require.NoError(t, err)
 	ctx.BuildOptionsJson = buildPropertiesJSON
 
-	commands := []types.Command{&builder.StoreBuildOptionsMap{}}
-	for _, command := range commands {
-		err := command.Run(ctx)
-		require.NoError(t, err)
-	}
+	err = builder.StoreBuildOptionsMap(ctx.BuildPath, ctx.BuildOptionsJson)
+	require.NoError(t, err)
 
 	exist, err := buildPath.Join(constants.BUILD_OPTIONS_FILE).ExistCheck()
 	require.NoError(t, err)