Migrate TestCompileWithLibraryPriority from test_compile_part_4.py to compile_part_4_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_4_test.go

@@ -60,3 +60,55 @@ func TestCompileWithLibrary(t *testing.T) {
 	require.NoError(t, err)
 	require.Contains(t, string(stdout), "WiFi101")
 }
+
+func TestCompileWithLibraryPriority(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")
+	require.NoError(t, err)
+
+	sketchName := "CompileSketchWithLibraryPriority"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	// Manually installs a library
+	gitUrl := "https://github.com/arduino-libraries/WiFi101.git"
+	manuallyInstalledLibPath := cli.SketchbookDir().Join("my-libraries", "WiFi101")
+	_, err = git.PlainClone(manuallyInstalledLibPath.String(), false, &git.CloneOptions{
+		URL:           gitUrl,
+		ReferenceName: plumbing.NewTagReferenceName("0.16.1"),
+	})
+	require.NoError(t, err)
+
+	// Install the same library we installed manually
+	_, _, err = cli.Run("lib", "install", "WiFi101")
+	require.NoError(t, err)
+
+	// Create new sketch and add library include
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+	sketchFile := sketchPath.Join(sketchName + ".ino")
+	lines, err := sketchFile.ReadFileAsLines()
+	require.NoError(t, err)
+	lines = append([]string{"#include <WiFi101.h>\n"}, lines...)
+	var data []byte
+	for _, l := range lines {
+		data = append(data, []byte(l)...)
+	}
+	err = sketchFile.WriteFile(data)
+	require.NoError(t, err)
+
+	stdout, _, err := cli.Run("compile", "-b", fqbn, sketchPath.String(), "--library", manuallyInstalledLibPath.String(), "-v")
+	require.NoError(t, err)
+	cliInstalledLibPath := cli.SketchbookDir().Join("libraries", "WiFi101")
+	expectedOutput := [3]string{
+		"Multiple libraries were found for \"WiFi101.h\"",
+		"  Used: " + manuallyInstalledLibPath.String(),
+		"  Not used: " + cliInstalledLibPath.String(),
+	}
+	require.Contains(t, string(stdout), expectedOutput[0]+"\n"+expectedOutput[1]+"\n"+expectedOutput[2]+"\n")
+}

test/test_compile_part_4.py

@@ -50,44 +50,6 @@ def test_compile_manually_installed_platform_using_boards_local_txt(run_command,
     assert run_command(["compile", "--clean", "-b", fqbn, sketch_path])
 
 
-def test_compile_with_library_priority(run_command, data_dir):
-    assert run_command(["update"])
-
-    assert run_command(["core", "install", "arduino:avr@1.8.3"])
-
-    sketch_name = "CompileSketchWithLibraryPriority"
-    sketch_path = Path(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    # Manually installs a library
-    git_url = "https://github.com/arduino-libraries/WiFi101.git"
-    manually_install_lib_path = Path(data_dir, "my-libraries", "WiFi101")
-    assert Repo.clone_from(git_url, manually_install_lib_path, multi_options=["-b 0.16.1"])
-
-    # Install the same library we installed manually
-    assert run_command(["lib", "install", "WiFi101"])
-
-    # Create new sketch and add library include
-    assert run_command(["sketch", "new", sketch_path])
-    sketch_file = sketch_path / f"{sketch_name}.ino"
-    lines = []
-    with open(sketch_file, "r") as f:
-        lines = f.readlines()
-    lines = ["#include <WiFi101.h>"] + lines
-    with open(sketch_file, "w") as f:
-        f.writelines(lines)
-
-    res = run_command(["compile", "-b", fqbn, sketch_path, "--library", manually_install_lib_path, "-v"])
-    assert res.ok
-    cli_installed_lib_path = Path(data_dir, "libraries", "WiFi101")
-    expected_output = [
-        'Multiple libraries were found for "WiFi101.h"',
-        f"  Used: {manually_install_lib_path}",
-        f"  Not used: {cli_installed_lib_path}",
-    ]
-    assert "\n".join(expected_output) in res.stdout
-
-
 def test_recompile_with_different_library(run_command, data_dir):
     assert run_command(["update"])