Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit be4c47a

Browse files
committedDec 15, 2022
Remove check-python-task and the related unused dependencies
1 parent 88deccb commit be4c47a

File tree

6 files changed

+209
-919
lines changed

6 files changed

+209
-919
lines changed
 

‎.flake8

Lines changed: 0 additions & 16 deletions
This file was deleted.

‎.github/workflows/check-python-task.yml

Lines changed: 0 additions & 86 deletions
This file was deleted.

‎Taskfile.yml

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -235,22 +235,6 @@ tasks:
235235
cmds:
236236
- clang-format -i rpc/cc/arduino/cli/*/*/*.proto
237237

238-
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-python-task/Taskfile.yml
239-
python:format:
240-
desc: Format Python files
241-
deps:
242-
- task: poetry:install-deps
243-
cmds:
244-
- poetry run black .
245-
246-
# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-python-task/Taskfile.yml
247-
python:lint:
248-
desc: Lint Python code
249-
deps:
250-
- task: poetry:install-deps
251-
cmds:
252-
- poetry run flake8 --show-source
253-
254238
build:
255239
desc: Build the project
256240
deps:
@@ -288,7 +272,6 @@ tasks:
288272
cmds:
289273
- task: go:vet
290274
- task: go:lint
291-
- task: python:lint
292275
- task: protoc:check
293276

294277
check-legacy:

‎docs/CONTRIBUTING.md

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -187,23 +187,6 @@ To run very specific test functions:
187187
go test -v github.com/arduino/arduino-cli/internal/integrationtest/lib -run TestLibUpgradeCommand
188188
```
189189

190-
#### Linting and formatting
191-
192-
When editing any Python file in the project remember to run linting checks with:
193-
194-
```shell
195-
task python:lint
196-
```
197-
198-
This will run `flake8` automatically and return any error in the code formatting, if not already installed it will also
199-
install integration tests dependencies.
200-
201-
In case of linting errors you should be able to solve most of them by automatically formatting with:
202-
203-
```shell
204-
task python:format
205-
```
206-
207190
### Dependency license metadata
208191

209192
Metadata about the license types of all dependencies is cached in the repository. To update this cache, run the

‎poetry.lock

Lines changed: 209 additions & 764 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pyproject.toml

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -6,29 +6,10 @@ authors = []
66

77
[tool.poetry.dependencies]
88
python = ">=3.8, !=3.9.7, <4"
9-
pytest = "6.0.2"
10-
simplejson = "3.17.0"
11-
semver = "2.13.0"
12-
pyserial = "3.4"
13-
pyyaml = "5.4"
14-
requests = "^2.22.0"
15-
pytest-timeout = "1.3.4"
16-
invoke = "1.4.1"
17-
filelock = "^3.0.12"
18-
pytest-xdist = "^2.1.0"
19-
pytest_httpserver = "^0.3.5"
20-
GitPython = "^3.1.12"
219

2210
[tool.poetry.dev-dependencies]
2311
mkdocs = "^1.2.1"
2412
mkdocs-material = "^7.1.8"
2513
mdx-truly-sane-lists = "^1.2"
2614
GitPython = "^3.1.20"
2715
mike = "^1.0.1"
28-
black = "^22.3"
29-
flake8 = "^3.9.2"
30-
pep8-naming = "^0.12.1"
31-
32-
[tool.black]
33-
line-length = 120
34-
target-version = ["py38"]

0 commit comments

Comments
 (0)
Please sign in to comment.