Libs and cores update is now correctly run only on first CLI execution

Author: silvanocerza

cli/instance/instance.go

@@ -20,7 +20,9 @@ import (
 
 	"github.com/arduino/arduino-cli/cli/output"
 	"github.com/arduino/arduino-cli/commands"
+	"github.com/arduino/arduino-cli/configuration"
 	rpc "github.com/arduino/arduino-cli/rpc/commands"
+	"github.com/arduino/go-paths-helper"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 )
@@ -51,9 +53,13 @@ func getInitResponse() (*rpc.InitResp, error) {
 		return nil, errors.Wrap(err, "creating instance")
 	}
 
-	// Init() succeeded but there were errors loading library indexes,
-	// let's rescan and try again
-	if resp.GetLibrariesIndexError() != "" {
+	// Gets the data directory to verify if library_index.json and package_index.json exist
+	dataDir := paths.New(configuration.Settings.GetString("directories.data"))
+
+	// The library_index.json file doesn't exists, that means the CLI is run for the first time
+	// so we proceed with the first update that downloads the file
+	libraryIndex := dataDir.Join("library_index.json")
+	if libraryIndex.NotExist() {
 		logrus.Warnf("There were errors loading the library index, trying again...")
 
 		// update all indexes
@@ -80,15 +86,11 @@ func getInitResponse() (*rpc.InitResp, error) {
 		resp.PlatformsIndexErrors = rescanResp.PlatformsIndexErrors
 	}
 
-	// Init() succeeded but there were errors loading platform indexes,
-	// let's rescan and try again
-	if resp.GetPlatformsIndexErrors() != nil {
-
-		// log each error
-		for _, err := range resp.GetPlatformsIndexErrors() {
-			logrus.Errorf("Error loading platform index: %v", err)
-		}
-
+	// The package_index.json file doesn't exists, that means the CLI is run for the first time,
+	// similarly to the library update we download that file and all the other package indexes
+	// from additional_urls
+	packageIndex := dataDir.Join("package_index.json")
+	if packageIndex.NotExist() {
 		// update platform index
 		_, err := commands.UpdateIndex(context.Background(),
 			&rpc.UpdateIndexReq{Instance: resp.GetInstance()}, output.ProgressBar())

test/test_compile.py

@@ -538,3 +538,26 @@ def test_compile_with_export_binaries_config(run_command, data_dir, downloads_di
     assert (sketch_path / "build" / fqbn.replace(":", ".") / f"{sketch_name}.ino.hex").exists()
     assert (sketch_path / "build" / fqbn.replace(":", ".") / f"{sketch_name}.ino.with_bootloader.bin").exists()
     assert (sketch_path / "build" / fqbn.replace(":", ".") / f"{sketch_name}.ino.with_bootloader.hex").exists()
+
+
+def test_compile_with_invalid_url(run_command, data_dir):
+    # Init the environment explicitly
+    run_command("core update-index")
+
+    # Download latest AVR
+    run_command("core install arduino:avr")
+
+    sketch_name = "CompileWithInvalidURL"
+    sketch_path = Path(data_dir, sketch_name)
+    fqbn = "arduino:avr:uno"
+
+    # Create a test sketch
+    assert run_command(f'sketch new "{sketch_path}"')
+
+    # Create settings with custom invalid URL
+    assert run_command("config init --dest-dir . --additional-urls https://example.com/package_example_index.json")
+
+    # Verifies compilation fails cause of invalid URL
+    res = run_command(f'compile -b {fqbn} "{sketch_path}"')
+    assert res.failed
+    assert "There were errors loading platform indexes" in res.stderr