Migrate TestUploadToPortWithBoardAutodetect from test_upload.py to upload_test.go

Author: MatteoPologruto

internal/integrationtest/upload/upload_test.go

@@ -525,3 +525,32 @@ func TestUploadSketchWithMismatchedCasing(t *testing.T) {
 		require.Contains(t, string(stderr), "Error during Upload:")
 	}
 }
+
+func TestUploadToPortWithBoardAutodetect(t *testing.T) {
+	if os.Getenv("CI") != "" {
+		t.Skip("VMs have no serial ports")
+	}
+
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Create a sketch
+	sketchPath := cli.SketchbookDir().Join("SketchSimple")
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+
+	for _, board := range detectedBoards(t, cli) {
+		// Install core
+		_, _, err = cli.Run("core", "install", board.core)
+		require.NoError(t, err)
+
+		_, _, err = cli.Run("compile", "-b", board.fqbn, sketchPath.String())
+		require.NoError(t, err)
+
+		_, _, err = cli.Run("upload", "-p", board.address, sketchPath.String())
+		require.NoError(t, err)
+	}
+}

test/test_upload.py

@@ -42,25 +42,6 @@ def test_upload_after_attach(run_command, data_dir, detected_boards):
         assert run_command(["upload", sketch_path])
 
 
-def test_upload_to_port_with_board_autodetect(run_command, data_dir, detected_boards):
-    assert run_command(["update"])
-
-    # Create a sketch
-    sketch_name = "SketchSimple"
-    sketch_path = Path(data_dir, sketch_name)
-    assert run_command(["sketch", "new", sketch_path])
-
-    for board in detected_boards:
-        # Install core
-        core = ":".join(board.fqbn.split(":")[:2])
-        assert run_command(["core", "install", core])
-
-        assert run_command(["compile", "-b", board.fqbn, sketch_path])
-
-        res = run_command(["upload", "-p", board.address, sketch_path])
-        assert res.ok
-
-
 def test_compile_and_upload_to_port_with_board_autodetect(run_command, data_dir, detected_boards):
     assert run_command(["update"])