Do not treat custom menu items without label as 'malformed'

Author: cmaglie

arduino/cores/packagemanager/loader.go

@@ -481,25 +481,8 @@ func (pm *Builder) loadBoards(platform *cores.PlatformRelease) error {
 	// set all other boards properties
 	delete(propertiesByBoard, "menu")
 
-	skippedBoards := []string{}
 	for boardID, boardProperties := range propertiesByBoard {
 		var board *cores.Board
-		for key := range boardProperties.AsMap() {
-			if !strings.HasPrefix(key, "menu.") {
-				continue
-			}
-			// Menu keys are formed like this:
-			//     menu.cache.off=false
-			//     menu.cache.on=true
-			// so we assume that the a second element in the slice exists
-			menuName := strings.Split(key, ".")[1]
-			if !platform.Menus.ContainsKey(menuName) {
-				fqbn := fmt.Sprintf("%s:%s:%s", platform.Platform.Package.Name, platform.Platform.Architecture, boardID)
-				skippedBoards = append(skippedBoards, fqbn)
-				goto next_board
-			}
-		}
-
 		if !platform.PluggableDiscoveryAware {
 			convertVidPidIdentificationPropertiesToPluggableDiscovery(boardProperties)
 			convertUploadToolsToPluggableDiscovery(boardProperties)
@@ -514,11 +497,6 @@ func (pm *Builder) loadBoards(platform *cores.PlatformRelease) error {
 		boardProperties.Set("_id", boardID)
 		board = platform.GetOrCreateBoard(boardID)
 		board.Properties.Merge(boardProperties)
-	next_board:
-	}
-
-	if len(skippedBoards) > 0 {
-		return fmt.Errorf(tr("skipping loading of boards %s: malformed custom board options"), strings.Join(skippedBoards, ", "))
 	}
 
 	return nil