Migrate TestCoreWithMissingCustomBoardOptionsIsLoaded from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -791,3 +791,43 @@ func TestCoreListPlatformWithoutPlatformTxt(t *testing.T) {
 	requirejson.Query(t, stdout, ".[] | .id", "\"some-packager:some-arch\"")
 	requirejson.Query(t, stdout, ".[] | .name", "\"some-packager-some-arch\"")
 }
+
+func TestCoreWithMissingCustomBoardOptionsIsLoaded(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Install platform in Sketchbook hardware dir
+	testPlatformName := "platform_with_missing_custom_board_options"
+	platformInstallDir := cli.SketchbookDir().Join("hardware", "arduino-beta-dev")
+	require.NoError(t, platformInstallDir.MkdirAll())
+	require.NoError(t, paths.New("..", "testdata", testPlatformName).CopyDirTo(platformInstallDir.Join(testPlatformName)))
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	stdout, _, err := cli.Run("core", "list", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Len(t, stdout, 1)
+	// Verifies platform is loaded except excluding board with missing options
+	requirejson.Contains(t, stdout, `[
+		{
+			"id": "arduino-beta-dev:platform_with_missing_custom_board_options"
+		}
+	]`)
+	requirejson.Query(t, stdout, ".[] | select(.id == \"arduino-beta-dev:platform_with_missing_custom_board_options\") | .boards | length", "2")
+	// Verify board with malformed options is not loaded
+	// while other board is loaded
+	requirejson.Contains(t, stdout, `[
+		{
+			"id": "arduino-beta-dev:platform_with_missing_custom_board_options",
+			"boards": [
+				{
+					"fqbn": "arduino-beta-dev:platform_with_missing_custom_board_options:nessuno"
+				},
+				{
+					"fqbn": "arduino-beta-dev:platform_with_missing_custom_board_options:altra"
+				}
+			]
+		}
+	]`)
+}

test/testdata/platform_with_missing_custom_board_options/boards.txt renamed to internal/integrationtest/testdata/platform_with_missing_custom_board_options/boards.txt

@@ -133,36 +133,6 @@ def test_core_download_multiple_platforms(run_command, data_dir):
     assert "Invalid argument passed: Found 2 platform for reference" in res.stderr
 
 
-def test_core_with_missing_custom_board_options_is_loaded(run_command, data_dir):
-    test_platform_name = "platform_with_missing_custom_board_options"
-    platform_install_dir = Path(data_dir, "hardware", "arduino-beta-dev", test_platform_name)
-    platform_install_dir.mkdir(parents=True)
-
-    # Install platform in Sketchbook hardware dir
-    shutil.copytree(
-        Path(__file__).parent / "testdata" / test_platform_name,
-        platform_install_dir,
-        dirs_exist_ok=True,
-    )
-
-    assert run_command(["update"])
-
-    res = run_command(["core", "list", "--format", "json"])
-    assert res.ok
-
-    cores = json.loads(res.stdout)
-    mapped = {core["id"]: core for core in cores}
-    assert len(mapped) == 1
-    # Verifies platform is loaded except excluding board with missing options
-    assert "arduino-beta-dev:platform_with_missing_custom_board_options" in mapped
-    boards = {b["fqbn"]: b for b in mapped["arduino-beta-dev:platform_with_missing_custom_board_options"]["boards"]}
-    assert len(boards) == 2
-    # Verify board with malformed options is not loaded
-    assert "arduino-beta-dev:platform_with_missing_custom_board_options:nessuno" in boards
-    # Verify other board is loaded
-    assert "arduino-beta-dev:platform_with_missing_custom_board_options:altra" in boards
-
-
 def test_core_list_outdated_core(run_command):
     assert run_command(["update"])