Skip to content

Commit 8b87a5c

Browse files
Migrate TestSketchArchiveAbsoluteSketchPathWithIncludeBuildDirFlag from test_sketch.py to sketch_test.go
1 parent 6c219da commit 8b87a5c

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

internal/integrationtest/sketch/sketch_test.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -597,3 +597,17 @@ func TestSketchArchiveRelativeSketchPathWithIncludeBuildDirFlag(t *testing.T) {
597597
defer require.NoError(t, archive.Close())
598598
verifyZipContainsSketchIncludingBuildDir(t, archive.File)
599599
}
600+
601+
func TestSketchArchiveAbsoluteSketchPathWithIncludeBuildDirFlag(t *testing.T) {
602+
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
603+
defer env.CleanUp()
604+
605+
_ = cli.CopySketch("sketch_simple")
606+
_, _, err := cli.Run("sketch", "archive", cli.WorkingDir().Join("sketch_simple").String(), "--include-build-dir")
607+
require.NoError(t, err)
608+
609+
archive, err := zip.OpenReader(cli.WorkingDir().Join("sketch_simple.zip").String())
610+
require.NoError(t, err)
611+
defer require.NoError(t, archive.Close())
612+
verifyZipContainsSketchIncludingBuildDir(t, archive.File)
613+
}

test/test_sketch.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,20 +48,6 @@ def verify_zip_contains_sketch_including_build_dir(files):
4848
assert "sketch_simple/build/arduino.avr.uno/sketch_simple.ino.with_bootloader.hex" in files
4949

5050

51-
def test_sketch_archive_absolute_sketch_path_with_include_build_dir_flag(run_command, copy_sketch, working_dir):
52-
result = run_command(
53-
["sketch", "archive", f"{working_dir}/sketch_simple", "--include-build-dir"], copy_sketch("sketch_simple")
54-
)
55-
assert result.ok
56-
57-
archive = zipfile.ZipFile(f"{working_dir}/sketch_simple.zip")
58-
archive_files = archive.namelist()
59-
60-
verify_zip_contains_sketch_including_build_dir(archive_files)
61-
62-
archive.close()
63-
64-
6551
def test_sketch_archive_relative_sketch_path_with_relative_zip_path_with_include_build_dir_flag(
6652
run_command, copy_sketch, working_dir
6753
):

0 commit comments

Comments
 (0)