Apply suggestions from code review

Co-authored-by: per1234 <accounts@perglass.com>

Author: cmaglie

Taskfile.yml

@@ -90,7 +90,7 @@ tasks:
 
   # Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/test-go-task/Taskfile.yml
   go:test:
-    desc: Run unit tests and part of the integration tests
+    desc: Run unit tests and the Go-based integration tests
     deps:
       - task: go:build
     dir: '{{default "./" .GO_MODULE_PATH}}'

internal/integrationtest/arduino-cli.go

@@ -61,7 +61,7 @@ func NewArduinoCliWithinEnvironment(env *testsuite.Environment, config *ArduinoC
 	cli := &ArduinoCLI{
 		path:          config.ArduinoCLIPath,
 		t:             require.New(env.T()),
-		dataDir:       env.RootDir().Join("arduino15"),
+		dataDir:       env.RootDir().Join("Arduino15"),
 		sketchbookDir: env.RootDir().Join("Arduino"),
 		stagingDir:    env.RootDir().Join("arduino15/staging"),
 	}
@@ -153,14 +153,6 @@ func (cli *ArduinoCLI) StartDaemon(verbose bool) string {
 
 	cli.t.NoError(cliProc.Start())
 	cli.proc = cliProc
-
-	// var daemonAddr struct {
-	// 	IP   string
-	// 	Port string
-	// }
-	// dec := json.NewDecoder(stdout)
-	// cli.t.NoError(dec.Decode(&daemonAddr))
-	// cli.daemonAddr = daemonAddr.IP + ":" + daemonAddr.Port
 	cli.daemonAddr = "127.0.0.1:50051"
 
 	copy := func(dst io.Writer, src io.Reader) {

internal/integrationtest/core/core_test.go

@@ -62,7 +62,6 @@ func TestCoreSearch(t *testing.T) {
 	out, _, err = cli.Run("core", "search", "test_core", "--all", "--format", "json", "--additional-urls="+url.String())
 	require.NoError(t, err)
 	requirejson.Len(t, out, 2)
-	// requirejson.Len(t, out, 3) // Test failure
 
 	checkPlatformIsInJSONOutput := func(stdout []byte, id, version string) {
 		jqquery := fmt.Sprintf(`[{id:"%s", latest:"%s"}]`, id, version)
@@ -74,7 +73,6 @@ func TestCoreSearch(t *testing.T) {
 	require.NoError(t, err)
 	checkPlatformIsInJSONOutput(out, "Retrokits-RK002:arm", "1.0.5")
 	checkPlatformIsInJSONOutput(out, "Retrokits-RK002:arm", "1.0.6")
-	//checkPlatformIsInJSONOutput(out, "Retrokits-RK002:arm", "1.0.9") // Test failure
 
 	// Search using Retrokit Package Maintainer
 	out, _, err = cli.Run("core", "search", "Retrokits-RK002", "--all", "--additional-urls="+url.String(), "--format", "json")
@@ -93,7 +91,6 @@ func TestCoreSearch(t *testing.T) {
 	require.NoError(t, err)
 	checkPlatformIsInJSONOutput(out, "Package:x86", "1.2.3")
 
-	// Check search with case, accents and spaces
 	runSearch := func(searchArgs string, expectedIDs ...string) {
 		args := []string{"core", "search", "--format", "json"}
 		args = append(args, strings.Split(searchArgs, " ")...)
@@ -106,6 +103,7 @@ func TestCoreSearch(t *testing.T) {
 		}
 	}
 
+	// Check search with case, accents and spaces
 	runSearch("mkr1000", "arduino:samd")
 	runSearch("mkr 1000", "arduino:samd")
 

internal/integrationtest/daemon/daemon_compile_test.go

@@ -74,9 +74,6 @@ func TestDaemonCompileOptions(t *testing.T) {
 			fmt.Println("COMPILE ERROR>", err)
 			break
 		}
-		// if msg.OutStream != nil {
-		// 	fmt.Printf("COMPILE> %v\n", string(msg.GetOutStream()))
-		// }
 		if msg.ErrStream != nil {
 			fmt.Printf("COMPILE> %v\n", string(msg.GetErrStream()))
 		}
@@ -91,9 +88,6 @@ func TestDaemonCompileOptions(t *testing.T) {
 			break
 		}
 		require.NoError(t, err)
-		// if msg.OutStream != nil {
-		// 	fmt.Printf("COMPILE> %v\n", string(msg.GetOutStream()))
-		// }
 		if msg.ErrStream != nil {
 			fmt.Printf("COMPILE> %v\n", string(msg.GetErrStream()))
 		}