Rename variables to use snakeCase (golang idiomatic)

Author: cmaglie

legacy/builder/container_find_includes.go

@@ -352,8 +352,8 @@ func findIncludesUntilDone(ctx *types.Context, cache *includeCache, sourceFile *
 			}
 		}
 
-		var preproc_err error
-		var preproc_stderr []byte
+		var preprocErr error
+		var preprocStderr []byte
 
 		var include string
 		if unchanged && cache.valid {
@@ -362,16 +362,16 @@ func findIncludesUntilDone(ctx *types.Context, cache *includeCache, sourceFile *
 				ctx.Info(tr("Using cached library dependencies for file: %[1]s", sourcePath))
 			}
 		} else {
-			preproc_stderr, preproc_err = GCCPreprocRunnerForDiscoveringIncludes(ctx, sourcePath, targetFilePath, includeFolders)
+			preprocStderr, preprocErr = GCCPreprocRunnerForDiscoveringIncludes(ctx, sourcePath, targetFilePath, includeFolders)
 			// Unwrap error and see if it is an ExitError.
-			if preproc_err == nil {
+			if preprocErr == nil {
 				// Preprocessor successful, done
 				include = ""
-			} else if _, isExitErr := errors.Cause(preproc_err).(*exec.ExitError); !isExitErr || preproc_stderr == nil {
+			} else if _, isExitErr := errors.Cause(preprocErr).(*exec.ExitError); !isExitErr || preprocStderr == nil {
 				// Ignore ExitErrors (e.g. gcc returning non-zero status), but bail out on other errors
-				return errors.WithStack(preproc_err)
+				return errors.WithStack(preprocErr)
 			} else {
-				include = IncludesFinderWithRegExp(string(preproc_stderr))
+				include = IncludesFinderWithRegExp(string(preprocStderr))
 				if include == "" && ctx.Verbose {
 					ctx.Info(tr("Error while detecting libraries included by %[1]s", sourcePath))
 				}
@@ -389,19 +389,19 @@ func findIncludesUntilDone(ctx *types.Context, cache *includeCache, sourceFile *
 			// Library could not be resolved, show error
 			// err := runCommand(ctx, &GCCPreprocRunner{SourceFilePath: sourcePath, TargetFileName: paths.New(constants.FILE_CTAGS_TARGET_FOR_GCC_MINUS_E), Includes: includes})
 			// return errors.WithStack(err)
-			if preproc_err == nil || preproc_stderr == nil {
+			if preprocErr == nil || preprocStderr == nil {
 				// Filename came from cache, so run preprocessor to obtain error to show
-				preproc_stderr, preproc_err = GCCPreprocRunnerForDiscoveringIncludes(ctx, sourcePath, targetFilePath, includeFolders)
-				if preproc_err == nil {
+				preprocStderr, preprocErr = GCCPreprocRunnerForDiscoveringIncludes(ctx, sourcePath, targetFilePath, includeFolders)
+				if preprocErr == nil {
 					// If there is a missing #include in the cache, but running
 					// gcc does not reproduce that, there is something wrong.
 					// Returning an error here will cause the cache to be
 					// deleted, so hopefully the next compilation will succeed.
 					return errors.New(tr("Internal error in cache"))
 				}
 			}
-			ctx.Stderr.Write(preproc_stderr)
-			return errors.WithStack(preproc_err)
+			ctx.Stderr.Write(preprocStderr)
+			return errors.WithStack(preprocErr)
 		}
 
 		// Add this library to the list of libraries, the