Migrated TestCompileWithMultipleBuildPropertyFlags to compile_part_1_test.go and deleted test_compile_part_1.py

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_1_test.go

@@ -415,3 +415,93 @@ func TestCompileWithBuildPropertyContainingQuotes(t *testing.T) {
 	require.NoError(t, err)
 	require.Contains(t, string(stdout), `-DMY_DEFINE=\"hello world\"`)
 }
+
+func TestCompileWithMultipleBuildPropertyFlags(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Install Arduino AVR Boards
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")
+	require.NoError(t, err)
+
+	// Copy sketch
+	sketchName := "sketch_with_multiple_defines"
+	p, err := paths.Getwd()
+	require.NoError(t, err)
+	require.NotNil(t, p)
+	testSketch := p.Parent().Join("testdata", sketchName)
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	err = testSketch.CopyDirTo(sketchPath)
+	require.NoError(t, err)
+
+	fqbn := "arduino:avr:uno"
+
+	// Compile using multiple build properties separated by a space
+	_, _, err = cli.Run(
+		"compile",
+		"-b",
+		fqbn,
+		"--build-property=compiler.cpp.extra_flags=\"-DPIN=2 -DSSID=\"This is a String\"\"",
+		sketchPath.String(),
+		"--verbose",
+		"--clean",
+	)
+	require.Error(t, err)
+
+	// Compile using multiple build properties separated by a space and properly quoted
+	stdout, _, err := cli.Run(
+		"compile",
+		"-b",
+		fqbn,
+		"--build-property=compiler.cpp.extra_flags=-DPIN=2 \"-DSSID=\"This is a String\"\"",
+		sketchPath.String(),
+		"--verbose",
+		"--clean",
+	)
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "-DPIN=2 \"-DSSID=\\\"This is a String\\\"\"")
+
+	// Tries compilation using multiple build properties separated by a comma
+	_, _, err = cli.Run(
+		"compile",
+		"-b",
+		fqbn,
+		"--build-property=compiler.cpp.extra_flags=\"-DPIN=2,-DSSID=\"This is a String\"\"",
+		sketchPath.String(),
+		"--verbose",
+		"--clean",
+	)
+	require.Error(t, err)
+
+	stdout, _, err = cli.Run(
+		"compile",
+		"-b",
+		fqbn,
+		"--build-property=compiler.cpp.extra_flags=\"-DPIN=2\"",
+		"--build-property=compiler.cpp.extra_flags=\"-DSSID=\"This is a String\"\"",
+		sketchPath.String(),
+		"--verbose",
+		"--clean",
+	)
+	require.Error(t, err)
+	require.NotContains(t, string(stdout), "-DPIN=2")
+	require.Contains(t, string(stdout), "-DSSID=\\\"This is a String\\\"")
+
+	stdout, _, err = cli.Run(
+		"compile",
+		"-b",
+		fqbn,
+		"--build-property=compiler.cpp.extra_flags=\"-DPIN=2\"",
+		"--build-property=build.extra_flags=\"-DSSID=\"hello world\"\"",
+		sketchPath.String(),
+		"--verbose",
+		"--clean",
+	)
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "-DPIN=2")
+	require.Contains(t, string(stdout), "-DSSID=\\\"hello world\\\"")
+}

internal/integrationtest/testdata/sketch_with_multiple_defines/sketch_with_multiple_defines.ino

@@ -0,0 +1,12 @@
+
+const int DEFAULT_PIN = PIN;
+const String DEFAULT_SSID = SSID;
+
+void setup() {
+    Serial.begin(9600);
+    Serial.println(DEFAULT_PIN);
+    Serial.println(DEFAULT_SSID);
+}
+
+void loop() {
+}