Remove direct os.Stdin access from daemon command

Author: cmaglie

cli/cli_test.go

@@ -73,6 +73,7 @@ func inspect(t *testing.T, fset *token.FileSet, node ast.Node) bool {
 		wanted := map[string]bool{
 			"os.Stdout": true,
 			"os.Stderr": true,
+			"os.Stdin":  true,
 		}
 		name := expr(n)
 		if wanted[name] {

cli/daemon/daemon.go

@@ -18,8 +18,6 @@ package daemon
 import (
 	"errors"
 	"fmt"
-	"io"
-	"io/ioutil"
 	"net"
 	"os"
 	"strings"
@@ -120,11 +118,7 @@ func runDaemonCommand(cmd *cobra.Command, args []string) {
 
 	if !daemonize {
 		// When parent process ends terminate also the daemon
-		go func() {
-			// Stdin is closed when the controlling parent process ends
-			_, _ = io.Copy(ioutil.Discard, os.Stdin)
-			os.Exit(0)
-		}()
+		go feedback.ExitWhenParentProcessEnds()
 	}
 
 	lis, err := net.Listen("tcp", fmt.Sprintf("%s:%s", ip, port))

cli/feedback/terminal.go

@@ -72,3 +72,13 @@ func InputUserField(prompt string, secret bool) (string, error) {
 
 	return string(value), nil
 }
+
+// ExitWhenParentProcessEnds waits until the controlling parent process ends and then exits
+// the current process. This is useful to terminate the current process when it is daemonized
+// and the controlling parent process is terminated to avoid leaving zombie processes.
+// It is recommended to call this function as a goroutine.
+func ExitWhenParentProcessEnds() {
+	// Stdin is closed when the controlling parent process ends
+	_, _ = io.Copy(io.Discard, os.Stdin)
+	os.Exit(0)
+}