Added output to new 'core list' command

Author: cmaglie

cli/core/list.go

@@ -19,9 +19,13 @@ package core
 
 import (
 	"context"
+	"fmt"
+	"os"
+	"sort"
 
 	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/commands/core"
+	"github.com/arduino/arduino-cli/common/formatter"
 	"github.com/arduino/arduino-cli/output"
 	"github.com/arduino/arduino-cli/rpc"
 	"github.com/spf13/cobra"
@@ -46,8 +50,30 @@ var listFlags struct {
 
 func runListCommand(cmd *cobra.Command, args []string) {
 	instance := cli.CreateInstance()
-	core.PlatformList(context.Background(), &rpc.PlatformListReq{
+	resp, err := core.PlatformList(context.Background(), &rpc.PlatformListReq{
 		Instance:      instance,
 		UpdatableOnly: listFlags.updatableOnly,
 	}, output.NewTaskProgressCB())
+	if err != nil {
+		formatter.PrintError(err, "Error saerching for platforms")
+		os.Exit(cli.ErrGeneric)
+	}
+	installed := resp.GetInstalledPlatform()
+	if installed != nil && len(installed) > 0 {
+		if cli.OutputJSONOrElse(installed) {
+			outputInstalledCores(installed)
+		}
+	}
+}
+
+func outputInstalledCores(cores []*rpc.InstalledPlatform) {
+	table := output.NewTable()
+	table.AddRow("ID", "Installed", "Latest", "Name")
+	sort.Slice(cores, func(i, j int) bool {
+		return cores[i].ID < cores[j].ID
+	})
+	for _, item := range cores {
+		table.AddRow(item.GetID(), item.GetInstalled(), item.GetLatest(), item.GetName())
+	}
+	fmt.Print(table.Render())
 }

commands/core/list.go

@@ -53,8 +53,5 @@ func PlatformList(ctx context.Context, req *rpc.PlatformListReq, taskCB commands
 		}
 	}
 
-	// if len(installed) > 0 {
-	// 	//formatter.Print(output.InstalledPlatforms{Platforms: installed})
-	// }
 	return &rpc.PlatformListResp{InstalledPlatform: installed}, nil
 }

common/formatter/output/core_structs.go

@@ -25,36 +25,6 @@ import (
 	semver "go.bug.st/relaxed-semver"
 )
 
-// InstalledPlatforms represents an output of a set of installed platforms.
-type InstalledPlatforms struct {
-	Platforms []*InstalledPlatform
-}
-
-// InstalledPlatform represents an output of an installed plaform.
-type InstalledPlatform struct {
-	ID        string
-	Installed *semver.Version
-	Latest    *semver.Version
-	Name      string
-}
-
-func (is InstalledPlatforms) less(i, j int) bool {
-	return is.Platforms[i].ID < is.Platforms[j].ID
-}
-
-func (is InstalledPlatforms) String() string {
-	table := uitable.New()
-	table.MaxColWidth = 100
-	table.Wrap = true
-
-	table.AddRow("ID", "Installed", "Latest", "Name")
-	sort.Slice(is.Platforms, is.less)
-	for _, item := range is.Platforms {
-		table.AddRow(item.ID, item.Installed, item.Latest, item.Name)
-	}
-	return fmt.Sprintln(table)
-}
-
 // SearchedPlatforms represents an output of a set of searched platforms
 type SearchedPlatforms struct {
 	Platforms []*SearchedPlatform