Migrate TestCompileWithRelativeBuildPath from test_compile_part_4.py to compile_part_4_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_4_test.go

@@ -449,6 +449,46 @@ func TestCompileSketchWithIppFileInclude(t *testing.T) {
 	require.NoError(t, err)
 }
 
+func TestCompileWithRelativeBuildPath(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")
+	require.NoError(t, err)
+
+	sketchName := "sketch_simple"
+	sketchPath := cli.CopySketch(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	buildPath := paths.New("..").Join("build_path")
+	workingDir := cli.SketchbookDir().Join("working_dir")
+	err = workingDir.Mkdir()
+	require.NoError(t, err)
+	cli.SetWorkingDir(workingDir)
+	_, _, err = cli.Run("compile", "-b", fqbn, "--build-path", buildPath.String(), sketchPath.String(), "-v")
+	require.NoError(t, err)
+	cli.SetWorkingDir(env.RootDir())
+
+	absoluteBuildPath := cli.SketchbookDir().Join("build_path")
+	builtFiles, err := absoluteBuildPath.ReadDir()
+	require.NoError(t, err)
+	require.Contains(t, builtFiles[8].String(), sketchName+".ino.eep")
+	require.Contains(t, builtFiles[9].String(), sketchName+".ino.elf")
+	require.Contains(t, builtFiles[10].String(), sketchName+".ino.hex")
+	require.Contains(t, builtFiles[11].String(), sketchName+".ino.with_bootloader.bin")
+	require.Contains(t, builtFiles[12].String(), sketchName+".ino.with_bootloader.hex")
+	require.Contains(t, builtFiles[0].String(), "build.options.json")
+	require.Contains(t, builtFiles[1].String(), "compile_commands.json")
+	require.Contains(t, builtFiles[2].String(), "core")
+	require.Contains(t, builtFiles[3].String(), "includes.cache")
+	require.Contains(t, builtFiles[4].String(), "libraries")
+	require.Contains(t, builtFiles[6].String(), "preproc")
+	require.Contains(t, builtFiles[7].String(), "sketch")
+}
+
 func TestCompileWithoutUploadAndFqbn(t *testing.T) {
 	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
 	defer env.CleanUp()

test/test_compile_part_4.py

@@ -20,39 +20,6 @@
 from pathlib import Path
 
 
-def test_compile_with_relative_build_path(run_command, data_dir, copy_sketch):
-    assert run_command(["update"])
-
-    run_command(["core", "install", "arduino:avr@1.8.3"])
-
-    sketch_name = "sketch_simple"
-    sketch_path = copy_sketch(sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    build_path = Path("..", "build_path")
-    working_dir = Path(data_dir, "working_dir")
-    working_dir.mkdir()
-    assert run_command(
-        ["compile", "-b", fqbn, "--build-path", build_path, sketch_path, "-v"],
-        custom_working_dir=working_dir,
-    )
-
-    absolute_build_path = Path(data_dir, "build_path")
-    built_files = [f.name for f in absolute_build_path.glob("*")]
-    assert f"{sketch_name}.ino.eep" in built_files
-    assert f"{sketch_name}.ino.elf" in built_files
-    assert f"{sketch_name}.ino.hex" in built_files
-    assert f"{sketch_name}.ino.with_bootloader.bin" in built_files
-    assert f"{sketch_name}.ino.with_bootloader.hex" in built_files
-    assert "build.options.json" in built_files
-    assert "compile_commands.json" in built_files
-    assert "core" in built_files
-    assert "includes.cache" in built_files
-    assert "libraries" in built_files
-    assert "preproc" in built_files
-    assert "sketch" in built_files
-
-
 def test_compile_with_fake_secure_boot_core(run_command, data_dir):
     assert run_command(["update"])