refactor function that checks for flags conflicts

Author: umbynos

cli/arguments/arguments.go

@@ -15,6 +15,25 @@
 
 package arguments
 
-import "github.com/arduino/arduino-cli/i18n"
+import (
+	"os"
+	"strings"
+
+	"github.com/arduino/arduino-cli/cli/errorcodes"
+	"github.com/arduino/arduino-cli/cli/feedback"
+	"github.com/arduino/arduino-cli/i18n"
+	"github.com/spf13/cobra"
+)
 
 var tr = i18n.Tr
+
+// CheckFlagsConflicts is a helper function useful to report errors when more than one conflicting flag is used
+func CheckFlagsConflicts(command *cobra.Command, flagNames ...string) {
+	for _, flagName := range flagNames {
+		if !command.Flag(flagName).Changed {
+			return
+		}
+	}
+	feedback.Errorf(tr("Can't use %s flags at the same time.", "--"+strings.Join(flagNames, " "+tr("and")+" --")))
+	os.Exit(errorcodes.ErrBadArgument)
+}

cli/config/init.go

@@ -18,6 +18,7 @@ package config
 import (
 	"os"
 
+	"github.com/arduino/arduino-cli/cli/arguments"
 	"github.com/arduino/arduino-cli/cli/errorcodes"
 	"github.com/arduino/arduino-cli/cli/feedback"
 	"github.com/arduino/arduino-cli/configuration"
@@ -46,7 +47,10 @@ func initInitCommand() *cobra.Command {
 			"  " + os.Args[0] + " config init --dest-dir /home/user/MyDirectory\n" +
 			"  " + os.Args[0] + " config init --dest-file /home/user/MyDirectory/my_settings.yaml",
 		Args: cobra.NoArgs,
-		Run:  runInitCommand,
+		PreRun: func(cmd *cobra.Command, args []string) {
+			arguments.CheckFlagsConflicts(cmd, "dest-file", "dest-dir")
+		},
+		Run: runInitCommand,
 	}
 	initCommand.Flags().StringVar(&destDir, "dest-dir", "", tr("Sets where to save the configuration file."))
 	initCommand.Flags().StringVar(&destFile, "dest-file", "", tr("Sets where to save the configuration file."))
@@ -55,10 +59,6 @@ func initInitCommand() *cobra.Command {
 }
 
 func runInitCommand(cmd *cobra.Command, args []string) {
-	if destFile != "" && destDir != "" {
-		feedback.Errorf(tr("Can't use both --dest-file and --dest-dir flags at the same time."))
-		os.Exit(errorcodes.ErrGeneric)
-	}
 
 	var configFileAbsPath *paths.Path
 	var absPath *paths.Path

test/test_config.py

@@ -144,7 +144,7 @@ def test_init_dest_flag_with_overwrite_flag(run_command, working_dir):
 def test_init_dest_and_config_file_flags(run_command, working_dir):
     result = run_command(["config", "init", "--dest-file", "some_other_path", "--dest-dir", "some_path"])
     assert result.failed
-    assert "Can't use both --dest-file and --dest-dir flags at the same time." in result.stderr
+    assert "Can't use --dest-file and --dest-dir flags at the same time." in result.stderr
 
 
 def test_init_config_file_flag_absolute_path(run_command, working_dir):