Skip to content

Commit 321372c

Browse files
cmagliecmaglie
authored
[skip-changelog] Some minor adjustments in the codebase (#2006)
* Updated go-paths-helper to v1.8.0 * Pass of go-fmt * Removed unused functions * Removed dep golang.org/x/crypto/ssh/terminal in favor of golang.org/x/term * Fixed wrong error message
1 parent 9193353 commit 321372c

File tree

13 files changed

+17
-88
lines changed

13 files changed

+17
-88
lines changed

‎.licenses/go/github.com/arduino/go-paths-helper.dep.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: github.com/arduino/go-paths-helper
3-
version: v1.7.0
3+
version: v1.8.0
44
type: go
55
summary:
66
homepage: https://pkg.go.dev/github.com/arduino/go-paths-helper

‎.licenses/go/golang.org/x/crypto/ssh/terminal.dep.yml‎

Lines changed: 0 additions & 63 deletions
This file was deleted.

‎arduino/discovery/discovery_client/go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ require (
1111
)
1212

1313
require (
14-
github.com/arduino/go-paths-helper v1.7.0 // indirect
14+
github.com/arduino/go-paths-helper v1.8.0 // indirect
1515
github.com/arduino/go-properties-orderedmap v1.7.1 // indirect
1616
github.com/golang/protobuf v1.5.2 // indirect
1717
github.com/konsorten/go-windows-terminal-sequences v1.0.1 // indirect

‎arduino/discovery/discovery_client/go.sum‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ github.com/anmitsu/go-shlex v0.0.0-20161002113705-648efa622239/go.mod h1:2FmKhYU
4444
github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY=
4545
github.com/arduino/go-paths-helper v1.0.1/go.mod h1:HpxtKph+g238EJHq4geEPv9p+gl3v5YYu35Yb+w31Ck=
4646
github.com/arduino/go-paths-helper v1.2.0/go.mod h1:HpxtKph+g238EJHq4geEPv9p+gl3v5YYu35Yb+w31Ck=
47-
github.com/arduino/go-paths-helper v1.7.0 h1:S9l5BP2aogz1CgyqqnncXt0PLpK4yvwOW/wu/LaR3tc=
48-
github.com/arduino/go-paths-helper v1.7.0/go.mod h1:V82BWgAAp4IbmlybxQdk9Bpkz8M4Qyx+RAFKaG9NuvU=
47+
github.com/arduino/go-paths-helper v1.8.0 h1:BfA1bq1XktnlqwfUDCoKbUqB3YFPe6X7szPSZj6Rdpk=
48+
github.com/arduino/go-paths-helper v1.8.0/go.mod h1:V82BWgAAp4IbmlybxQdk9Bpkz8M4Qyx+RAFKaG9NuvU=
4949
github.com/arduino/go-properties-orderedmap v1.7.1 h1:HQ9Pn/mk3+XyfrE39EEvaZwJkrvgiVSY5Oq3JSEfOR4=
5050
github.com/arduino/go-properties-orderedmap v1.7.1/go.mod h1:DKjD2VXY/NZmlingh4lSFMEYCVubfeArCsGPGDwb2yk=
5151
github.com/arduino/go-timeutils v0.0.0-20171220113728-d1dd9e313b1b/go.mod h1:uwGy5PpN4lqW97FiLnbcx+xx8jly5YuPMJWfVwwjJiQ=

‎arduino/errors.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ func (e *InvalidProfileError) ToRPCStatus() *status.Status {
235235
type MissingPortAddressError struct{}
236236

237237
func (e *MissingPortAddressError) Error() string {
238-
return tr("Missing port protocol")
238+
return tr("Missing port address")
239239
}
240240

241241
// ToRPCStatus converts the error into a *status.Status

‎cli/arguments/user_fields.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222

2323
"github.com/arduino/arduino-cli/cli/feedback"
2424
rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
25-
"golang.org/x/crypto/ssh/terminal"
25+
"golang.org/x/term"
2626
)
2727

2828
// AskForUserFields prompts the user to input the provided user fields.
@@ -36,7 +36,7 @@ func AskForUserFields(userFields []*rpc.UserField) map[string]string {
3636
var value []byte
3737
var err error
3838
if f.Secret {
39-
value, err = terminal.ReadPassword(int(os.Stdin.Fd()))
39+
value, err = term.ReadPassword(int(os.Stdin.Fd()))
4040
} else {
4141
value, err = reader.ReadBytes('\n')
4242
}

‎cli/output/rpc_progress.go‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -93,11 +93,6 @@ func NewDownloadProgressBarCB() func(*rpc.DownloadProgress) {
9393
}
9494
}
9595

96-
// NewNullDownloadProgressCB returns a progress bar callback that outputs nothing.
97-
func NewNullDownloadProgressCB() func(*rpc.DownloadProgress) {
98-
return func(*rpc.DownloadProgress) {}
99-
}
100-
10196
// NewTaskProgressCB returns a commands.TaskProgressCB progress listener
10297
// that outputs to terminal
10398
func NewTaskProgressCB() func(curr *rpc.TaskProgress) {
@@ -121,8 +116,3 @@ func NewTaskProgressCB() func(curr *rpc.TaskProgress) {
121116
}
122117
}
123118
}
124-
125-
// NewNullTaskProgressCB returns a progress bar callback that outputs nothing.
126-
func NewNullTaskProgressCB() func(curr *rpc.TaskProgress) {
127-
return func(curr *rpc.TaskProgress) {}
128-
}

‎client_example/go.sum‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ github.com/anmitsu/go-shlex v0.0.0-20161002113705-648efa622239/go.mod h1:2FmKhYU
4444
github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY=
4545
github.com/arduino/go-paths-helper v1.0.1/go.mod h1:HpxtKph+g238EJHq4geEPv9p+gl3v5YYu35Yb+w31Ck=
4646
github.com/arduino/go-paths-helper v1.2.0/go.mod h1:HpxtKph+g238EJHq4geEPv9p+gl3v5YYu35Yb+w31Ck=
47-
github.com/arduino/go-paths-helper v1.7.0/go.mod h1:V82BWgAAp4IbmlybxQdk9Bpkz8M4Qyx+RAFKaG9NuvU=
47+
github.com/arduino/go-paths-helper v1.8.0/go.mod h1:V82BWgAAp4IbmlybxQdk9Bpkz8M4Qyx+RAFKaG9NuvU=
4848
github.com/arduino/go-properties-orderedmap v1.7.1/go.mod h1:DKjD2VXY/NZmlingh4lSFMEYCVubfeArCsGPGDwb2yk=
4949
github.com/arduino/go-timeutils v0.0.0-20171220113728-d1dd9e313b1b/go.mod h1:uwGy5PpN4lqW97FiLnbcx+xx8jly5YuPMJWfVwwjJiQ=
5050
github.com/arduino/go-win32-utils v0.0.0-20180330194947-ed041402e83b/go.mod h1:iIPnclBMYm1g32Q5kXoqng4jLhMStReIP7ZxaoUC2y8=

‎commands/upload/upload.go‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -629,11 +629,13 @@ func detectSketchNameFromBuildPath(buildPath *paths.Path) (string, error) {
629629
// specified protocol properties.
630630
//
631631
// For example passing the below properties and "upload" as action and "serial" as protocol:
632+
//
632633
// upload.speed=256
633634
// upload.serial.speed=57600
634635
// upload.network.speed=19200
635636
//
636637
// will return:
638+
//
637639
// upload.speed=57600
638640
// upload.serial.speed=57600
639641
// upload.network.speed=19200

‎docsgen/go.mod‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ require (
1111
)
1212

1313
require (
14-
github.com/arduino/go-paths-helper v1.7.0 // indirect
14+
github.com/arduino/go-paths-helper v1.8.0 // indirect
1515
github.com/arduino/go-properties-orderedmap v1.7.1 // indirect
1616
github.com/arduino/go-timeutils v0.0.0-20171220113728-d1dd9e313b1b // indirect
1717
github.com/arduino/go-win32-utils v0.0.0-20180330194947-ed041402e83b // indirect

0 commit comments

Comments
 (0)