Migrate TestSearch from test_lib.py to lib_test.go

Author: MatteoPologruto

internal/integrationtest/lib/lib_test.go

@@ -17,6 +17,7 @@ package lib_test
 
 import (
 	"encoding/json"
+	"fmt"
 	"io"
 	"net/http"
 	"strings"
@@ -718,3 +719,48 @@ func TestLibOpsCaseInsensitive(t *testing.T) {
 	require.NoError(t, err)
 	requirejson.Len(t, stdout, 0)
 }
+
+func TestSearch(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	stdout, _, err := cli.Run("lib", "search", "--names")
+	require.NoError(t, err)
+	lines := strings.Split(strings.TrimSpace(string(stdout)), "\n")
+	var libs []string
+	for i, v := range lines {
+		lines[i] = strings.TrimSpace(v)
+		if strings.Contains(v, "Name:") {
+			libs = append(libs, strings.Trim(strings.SplitN(v, " ", 2)[1], "\""))
+		}
+	}
+
+	expected := []string{"WiFi101", "WiFi101OTA", "Firebase Arduino based on WiFi101", "WiFi101_Generic"}
+	require.Subset(t, libs, expected)
+
+	stdout, _, err = cli.Run("lib", "search", "--names", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Query(t, stdout, ".libraries | length", fmt.Sprint(len(libs)))
+
+	runSearch := func(args string, expectedLibs []string) {
+		stdout, _, err = cli.Run("lib", "search", "--names", "--format", "json", args)
+		require.NoError(t, err)
+		libraries := requirejson.Parse(t, stdout).Query("[ .libraries | .[] | .name ]").String()
+		for _, l := range expectedLibs {
+			require.Contains(t, libraries, l)
+		}
+	}
+	runSearch("Arduino_MKRIoTCarrier", []string{"Arduino_MKRIoTCarrier"})
+	runSearch("Arduino mkr iot carrier", []string{"Arduino_MKRIoTCarrier"})
+	runSearch("mkr iot carrier", []string{"Arduino_MKRIoTCarrier"})
+	runSearch("mkriotcarrier", []string{"Arduino_MKRIoTCarrier"})
+	runSearch("dht", []string{"DHT sensor library", "DHT sensor library for ESPx", "DHT12", "SimpleDHT", "TinyDHT sensor library", "SDHT"})
+	runSearch("dht11", []string{"DHT sensor library", "DHT sensor library for ESPx", "SimpleDHT", "SDHT"})
+	runSearch("dht12", []string{"DHT12", "DHT12 sensor library", "SDHT"})
+	runSearch("dht22", []string{"DHT sensor library", "DHT sensor library for ESPx", "SimpleDHT", "SDHT"})
+	runSearch("dht sensor", []string{"DHT sensor library", "DHT sensor library for ESPx", "SimpleDHT", "SDHT"})
+	runSearch("sensor dht", []string{})
+	runSearch("arduino json", []string{"ArduinoJson", "Arduino_JSON"})
+	runSearch("arduinojson", []string{"ArduinoJson"})
+	runSearch("json", []string{"ArduinoJson", "Arduino_JSON"})
+}

test/test_lib.py

@@ -146,54 +146,6 @@ def test_install_with_zip_path(run_command, data_dir, downloads_dir):
     assert lib_install_dir / "README.adoc" in files
 
 
-def test_search(run_command):
-    assert run_command(["update"])
-
-    result = run_command(["lib", "search", "--names"])
-    assert result.ok
-    lines = [l.strip() for l in result.stdout.strip().splitlines()]
-    assert "Downloading index: library_index.tar.bz2 downloaded" in lines
-    libs = [l[6:].strip('"') for l in lines if "Name:" in l]
-
-    expected = {"WiFi101", "WiFi101OTA", "Firebase Arduino based on WiFi101", "WiFi101_Generic"}
-    assert expected == {lib for lib in libs if "WiFi101" in lib}
-
-    result = run_command(["lib", "search", "--names", "--format", "json"])
-    assert result.ok
-    libs_json = json.loads(result.stdout)
-    assert len(libs) == len(libs_json.get("libraries"))
-
-    result = run_command(["lib", "search", "--names"])
-    assert result.ok
-
-    def run_search(search_args, expected_libraries):
-        res = run_command(["lib", "search", "--names", "--format", "json"] + search_args.split(" "))
-        assert res.ok
-        data = json.loads(res.stdout)
-        libraries = [l["name"] for l in data["libraries"]]
-        for l in expected_libraries:
-            assert l in libraries
-
-    run_search("Arduino_MKRIoTCarrier", ["Arduino_MKRIoTCarrier"])
-    run_search("Arduino mkr iot carrier", ["Arduino_MKRIoTCarrier"])
-    run_search("mkr iot carrier", ["Arduino_MKRIoTCarrier"])
-    run_search("mkriotcarrier", ["Arduino_MKRIoTCarrier"])
-
-    run_search(
-        "dht",
-        ["DHT sensor library", "DHT sensor library for ESPx", "DHT12", "SimpleDHT", "TinyDHT sensor library", "SDHT"],
-    )
-    run_search("dht11", ["DHT sensor library", "DHT sensor library for ESPx", "SimpleDHT", "SDHT"])
-    run_search("dht12", ["DHT12", "DHT12 sensor library", "SDHT"])
-    run_search("dht22", ["DHT sensor library", "DHT sensor library for ESPx", "SimpleDHT", "SDHT"])
-    run_search("dht sensor", ["DHT sensor library", "DHT sensor library for ESPx", "SimpleDHT", "SDHT"])
-    run_search("sensor dht", [])
-
-    run_search("arduino json", ["ArduinoJson", "Arduino_JSON"])
-    run_search("arduinojson", ["ArduinoJson"])
-    run_search("json", ["ArduinoJson", "Arduino_JSON"])
-
-
 def test_search_paragraph(run_command):
     """
     Search for a string that's only present in the `paragraph` field