Migrate TestCoreUpgradeRemovesUnusedTools from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -488,3 +488,26 @@ func TestCoreListUpdatableAllFlags(t *testing.T) {
 			}
 		]`)
 }
+
+func TestCoreUpgradeRemovesUnusedTools(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Installs a core
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.2")
+	require.NoError(t, err)
+
+	// Verifies expected tool is installed
+	toolPath := cli.DataDir().Join("packages", "arduino", "tools", "avr-gcc", "7.3.0-atmel3.6.1-arduino5")
+	require.DirExists(t, toolPath.String())
+
+	// Upgrades core
+	_, _, err = cli.Run("core", "upgrade", "arduino:avr")
+	require.NoError(t, err)
+
+	// Verifies tool is uninstalled since it's not used by newer core version
+	require.NoDirExists(t, toolPath.String())
+}

test/test_core.py

@@ -68,23 +68,6 @@ def ordered(obj):
     assert ordered(installed_json) == ordered(expected_installed_json)
 
 
-def test_core_upgrade_removes_unused_tools(run_command, data_dir):
-    assert run_command(["update"])
-
-    # Installs a core
-    assert run_command(["core", "install", "arduino:avr@1.8.2"])
-
-    # Verifies expected tool is installed
-    tool_path = Path(data_dir, "packages", "arduino", "tools", "avr-gcc", "7.3.0-atmel3.6.1-arduino5")
-    assert tool_path.exists()
-
-    # Upgrades core
-    assert run_command(["core", "upgrade", "arduino:avr"])
-
-    # Verifies tool is uninstalled since it's not used by newer core version
-    assert not tool_path.exists()
-
-
 def test_core_install_removes_unused_tools(run_command, data_dir):
     assert run_command(["update"])