Migrate TestCoreUninstallToolDependencyRemoval from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -320,3 +320,28 @@ func TestCoreUninstall(t *testing.T) {
 	require.NoError(t, err)
 	requirejson.Empty(t, stdout)
 }
+
+func TestCoreUninstallToolDependencyRemoval(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// These platforms both have a dependency on the arduino:avr-gcc@7.3.0-atmel3.6.1-arduino5 tool
+	// arduino:avr@1.8.2 has a dependency on arduino:avrdude@6.3.0-arduino17
+	_, _, err := cli.Run("core", "install", "arduino:avr@1.8.2")
+	require.NoError(t, err)
+	// arduino:megaavr@1.8.4 has a dependency on arduino:avrdude@6.3.0-arduino16
+	_, _, err = cli.Run("core", "install", "arduino:megaavr@1.8.4")
+	require.NoError(t, err)
+	_, _, err = cli.Run("core", "uninstall", "arduino:avr")
+	require.NoError(t, err)
+
+	arduinoToolsPath := cli.DataDir().Join("packages", "arduino", "tools")
+
+	avrGccBinariesPath := arduinoToolsPath.Join("avr-gcc", "7.3.0-atmel3.6.1-arduino5", "bin")
+	// The tool arduino:avr-gcc@7.3.0-atmel3.6.1-arduino5 that is a dep of another installed platform should remain
+	require.True(t, avrGccBinariesPath.Join("avr-gcc").Exist() || avrGccBinariesPath.Join("avr-gcc.exe").Exist())
+
+	avrDudeBinariesPath := arduinoToolsPath.Join("avrdude", "6.3.0-arduino17", "bin")
+	// The tool arduino:avrdude@6.3.0-arduino17 that is only a dep of arduino:avr should have been removed
+	require.False(t, avrDudeBinariesPath.Join("avrdude").Exist() || avrDudeBinariesPath.Join("avrdude.exe").Exist())
+}

test/test_core.py

@@ -47,27 +47,6 @@ def test_core_install_esp32(run_command, data_dir):
     assert (build_dir / f"{sketch_name}.ino.partitions.bin").exists()
 
 
-def test_core_uninstall_tool_dependency_removal(run_command, data_dir):
-    # These platforms both have a dependency on the arduino:avr-gcc@7.3.0-atmel3.6.1-arduino5 tool
-    # arduino:avr@1.8.2 has a dependency on arduino:avrdude@6.3.0-arduino17
-    assert run_command(["core", "install", "arduino:avr@1.8.2"])
-    # arduino:megaavr@1.8.4 has a dependency on arduino:avrdude@6.3.0-arduino16
-    assert run_command(["core", "install", "arduino:megaavr@1.8.4"])
-    assert run_command(["core", "uninstall", "arduino:avr"])
-
-    arduino_tools_path = Path(data_dir, "packages", "arduino", "tools")
-
-    avr_gcc_binaries_path = arduino_tools_path.joinpath("avr-gcc", "7.3.0-atmel3.6.1-arduino5", "bin")
-    # The tool arduino:avr-gcc@7.3.0-atmel3.6.1-arduino5 that is a dep of another installed platform should remain
-    assert avr_gcc_binaries_path.joinpath("avr-gcc").exists() or avr_gcc_binaries_path.joinpath("avr-gcc.exe").exists()
-
-    avrdude_binaries_path = arduino_tools_path.joinpath("avrdude", "6.3.0-arduino17", "bin")
-    # The tool arduino:avrdude@6.3.0-arduino17 that is only a dep of arduino:avr should have been removed
-    assert (
-        avrdude_binaries_path.joinpath("avrdude").exists() or avrdude_binaries_path.joinpath("avrdude.exe").exists()
-    ) is False
-
-
 def test_core_zipslip(run_command):
     url = "https://raw.githubusercontent.com/arduino/arduino-cli/master/test/testdata/test_index.json"
     assert run_command(["core", "update-index", f"--additional-urls={url}"])