Migrate TestGenerateCompileCommandsJsonResilience from test_compile_part_4.py to compile_part_4_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_4_test.go

@@ -342,3 +342,27 @@ func TestCompileWithEsp8266BundledLibraries(t *testing.T) {
 	}
 	require.NotContains(t, string(stdout), expectedOutput[0]+"\n"+expectedOutput[1]+"\n"+expectedOutput[2]+"\n")
 }
+
+func TestGenerateCompileCommandsJsonResilience(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// check it didn't fail with esp32@2.0.1 that has a prebuild hook that must run:
+	// https://github.com/arduino/arduino-cli/issues/1547
+	url := "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json"
+	_, _, err = cli.Run("core", "update-index", "--additional-urls="+url)
+	require.NoError(t, err)
+	_, _, err = cli.Run("core", "install", "esp32:esp32@2.0.1", "--additional-urls="+url)
+	require.NoError(t, err)
+	sketchPath := cli.CopySketch("sketch_simple")
+	_, _, err = cli.Run("compile", "-b", "esp32:esp32:featheresp32", "--only-compilation-database", sketchPath.String())
+	require.NoError(t, err)
+
+	// check it didn't fail on a sketch with a missing include
+	sketchPath = cli.CopySketch("sketch_with_missing_include")
+	_, _, err = cli.Run("compile", "-b", "esp32:esp32:featheresp32", "--only-compilation-database", sketchPath.String())
+	require.NoError(t, err)
+}

test/testdata/sketch_with_missing_include/sketch_with_missing_include.ino renamed to internal/integrationtest/testdata/sketch_with_missing_include/sketch_with_missing_include.ino

@@ -50,22 +50,6 @@ def test_compile_manually_installed_platform_using_boards_local_txt(run_command,
     assert run_command(["compile", "--clean", "-b", fqbn, sketch_path])
 
 
-def test_generate_compile_commands_json_resilience(run_command, data_dir, copy_sketch):
-    assert run_command(["update"])
-
-    # check it didn't fail with esp32@2.0.1 that has a prebuild hook that must run:
-    # https://github.com/arduino/arduino-cli/issues/1547
-    url = "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json"
-    assert run_command(["core", "update-index", f"--additional-urls={url}"])
-    assert run_command(["core", "install", "esp32:esp32@2.0.1", f"--additional-urls={url}"])
-    sketch_path = copy_sketch("sketch_simple")
-    assert run_command(["compile", "-b", "esp32:esp32:featheresp32", "--only-compilation-database", sketch_path])
-
-    # check it didn't fail on a sketch with a missing include
-    sketch_path = copy_sketch("sketch_with_missing_include")
-    assert run_command(["compile", "-b", "esp32:esp32:featheresp32", "--only-compilation-database", sketch_path])
-
-
 def test_compile_sketch_with_tpp_file_include(run_command, copy_sketch):
     assert run_command(["update"])