use strings.ReplaceAll instead of Replace with -1

Author: alessio-perugini

arduino/builder/cpp/cpp.go

@@ -27,8 +27,8 @@ import (
 // preprocessor. This adds double quotes around it and escapes any
 // double quotes and backslashes in the string.
 func QuoteString(str string) string {
-	str = strings.Replace(str, "\\", "\\\\", -1)
-	str = strings.Replace(str, "\"", "\\\"", -1)
+	str = strings.ReplaceAll(str, "\\", "\\\\")
+	str = strings.ReplaceAll(str, "\"", "\\\"")
 	return "\"" + str + "\""
 }
 

arduino/builder/preprocessor/ctags.go

@@ -103,8 +103,8 @@ func PreprocessSketchWithCtags(sketch *sketch.Sketch, buildPath *paths.Path, inc
 	} else {
 		return normalOutput.Bytes(), verboseOutput.Bytes(), err
 	}
-	source = strings.Replace(source, "\r\n", "\n", -1)
-	source = strings.Replace(source, "\r", "\n", -1)
+	source = strings.ReplaceAll(source, "\r\n", "\n")
+	source = strings.ReplaceAll(source, "\r", "\n")
 	sourceRows := strings.Split(source, "\n")
 	if isFirstFunctionOutsideOfSource(firstFunctionLine, sourceRows) {
 		return normalOutput.Bytes(), verboseOutput.Bytes(), nil

arduino/builder/preprocessor/internal/ctags/ctags_parser.go

@@ -167,8 +167,8 @@ func removeTralingSemicolon(s string) string {
 }
 
 func removeSpacesAndTabs(s string) string {
-	s = strings.Replace(s, " ", "", -1)
-	s = strings.Replace(s, "\t", "", -1)
+	s = strings.ReplaceAll(s, " ", "")
+	s = strings.ReplaceAll(s, "\t", "")
 	return s
 }
 
@@ -205,7 +205,7 @@ func parseTag(row string) *Tag {
 	// and just cuts off the filename at the first double quote it
 	// sees. This means any backslashes are still escaped, and need
 	// to be unescape, and any quotes will just break the build.
-	tag.Filename = strings.Replace(parts[1], "\\\\", "\\", -1)
+	tag.Filename = strings.ReplaceAll(parts[1], "\\\\", "\\")
 
 	parts = parts[2:]
 

commands/compile/compile.go

@@ -310,7 +310,7 @@ func Compile(ctx context.Context, req *rpc.CompileRequest, outStream, errStream
 			exportPath = paths.New(exportDir)
 		} else {
 			// Add FQBN (without configs part) to export path
-			fqbnSuffix := strings.Replace(fqbn.StringWithoutConfig(), ":", ".", -1)
+			fqbnSuffix := strings.ReplaceAll(fqbn.StringWithoutConfig(), ":", ".")
 			exportPath = sk.FullPath.Join("build", fqbnSuffix)
 		}
 		logrus.WithField("path", exportPath).Trace("Saving sketch to export path.")

i18n/convert.go

@@ -34,11 +34,11 @@ func FromJavaToGoSyntax(s string) string {
 		if err != nil {
 			panic(err)
 		}
-		s = strings.Replace(s, submatch[0], "%["+strconv.Itoa(idx+1)+"]v", -1)
+		s = strings.ReplaceAll(s, submatch[0], "%["+strconv.Itoa(idx+1)+"]v")
 	}
 
 	// Replace "''" => "'"
-	s = strings.Replace(s, "''", "'", -1)
+	s = strings.ReplaceAll(s, "''", "'")
 
 	return s
 }

internal/cli/lib/search.go

@@ -163,7 +163,7 @@ func (res result) String() string {
 		out.WriteString(fmt.Sprintf("  "+tr("Category: %s")+"\n", latest.Category))
 		out.WriteString(fmt.Sprintf("  "+tr("Architecture: %s")+"\n", strings.Join(latest.Architectures, ", ")))
 		out.WriteString(fmt.Sprintf("  "+tr("Types: %s")+"\n", strings.Join(latest.Types, ", ")))
-		out.WriteString(fmt.Sprintf("  "+tr("Versions: %s")+"\n", strings.Replace(fmt.Sprint(lib.GetAvailableVersions()), " ", ", ", -1)))
+		out.WriteString(fmt.Sprintf("  "+tr("Versions: %s")+"\n", strings.ReplaceAll(fmt.Sprint(lib.GetAvailableVersions()), " ", ", ")))
 		if len(latest.ProvidesIncludes) > 0 {
 			out.WriteString(fmt.Sprintf("  "+tr("Provides includes: %s")+"\n", strings.Join(latest.ProvidesIncludes, ", ")))
 		}

internal/integrationtest/compile_4/compile_test.go

@@ -904,7 +904,7 @@ func comparePreprocessGoldenFile(t *testing.T, sketchDir *paths.Path, preprocess
 	err = tpl.Execute(&buf, data)
 	require.NoError(t, err)
 
-	require.Equal(t, buf.String(), strings.Replace(preprocessedSketch, "\r\n", "\n", -1))
+	require.Equal(t, buf.String(), strings.ReplaceAll(preprocessedSketch, "\r\n", "\n"))
 }
 
 func TestCoreCaching(t *testing.T) {