Big refactoring for daemon mode

All the arduino-cli commands implementation has been moved from package
`command` to package `cli`.

The `board details` command has been choosen as a 'tracing bullet' to
reimplement all the cli command using grpc/protoc to generate
Request/Response (input/output) structures.

We should probably abandon the idea to use a generic `formatter` module
since it seems that it doesn't help to reduce boilerplate code (for
example in the `board details` command there is no need for the
`formatter` module nor it's clear how it can improve things).

The `output` module now has only functions for pretty-printing data.

Author: cmaglie

commands/board/attach.go renamed to cli/board/attach.go

@@ -27,7 +27,7 @@ import (
 	"github.com/arduino/arduino-cli/arduino/cores"
 	"github.com/arduino/arduino-cli/arduino/cores/packagemanager"
 	"github.com/arduino/arduino-cli/arduino/sketches"
-	"github.com/arduino/arduino-cli/commands"
+	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/common/formatter"
 	discovery "github.com/arduino/board-discovery"
 	paths "github.com/arduino/go-paths-helper"
@@ -40,9 +40,9 @@ func initAttachCommand() *cobra.Command {
 		Use:   "attach <port>|<FQBN> [sketchPath]",
 		Short: "Attaches a sketch to a board.",
 		Long:  "Attaches a sketch to a board.",
-		Example: "  " + commands.AppName + " board attach serial:///dev/tty/ACM0\n" +
-			"  " + commands.AppName + " board attach serial:///dev/tty/ACM0 HelloWorld\n" +
-			"  " + commands.AppName + " board attach arduino:samd:mkr1000",
+		Example: "  " + cli.AppName + " board attach serial:///dev/tty/ACM0\n" +
+			"  " + cli.AppName + " board attach serial:///dev/tty/ACM0 HelloWorld\n" +
+			"  " + cli.AppName + " board attach arduino:samd:mkr1000",
 		Args: cobra.RangeArgs(1, 2),
 		Run:  runAttachCommand,
 	}
@@ -64,10 +64,10 @@ func runAttachCommand(cmd *cobra.Command, args []string) {
 	if len(args) > 1 {
 		sketchPath = paths.New(args[1])
 	}
-	sketch, err := commands.InitSketch(sketchPath)
+	sketch, err := cli.InitSketch(sketchPath)
 	if err != nil {
 		formatter.PrintError(err, "Error opening sketch.")
-		os.Exit(commands.ErrGeneric)
+		os.Exit(cli.ErrGeneric)
 	}
 
 	logrus.WithField("fqbn", boardURI).Print("Parsing FQBN")
@@ -76,7 +76,7 @@ func runAttachCommand(cmd *cobra.Command, args []string) {
 		boardURI = "serial://" + boardURI
 	}
 
-	pm := commands.InitPackageManager()
+	pm := cli.InitPackageManager()
 
 	if fqbn != nil {
 		sketch.Metadata.CPU = sketches.BoardMetadata{
@@ -86,7 +86,7 @@ func runAttachCommand(cmd *cobra.Command, args []string) {
 		deviceURI, err := url.Parse(boardURI)
 		if err != nil {
 			formatter.PrintError(err, "The provided Device URL is not in a valid format.")
-			os.Exit(commands.ErrBadCall)
+			os.Exit(cli.ErrBadCall)
 		}
 
 		var findBoardFunc func(*packagemanager.PackageManager, *discovery.Monitor, *url.URL) *cores.Board
@@ -97,7 +97,7 @@ func runAttachCommand(cmd *cobra.Command, args []string) {
 			findBoardFunc = findNetworkConnectedBoard
 		default:
 			formatter.PrintErrorMessage("Invalid device port type provided. Accepted types are: serial://, tty://, http://, https://, tcp://, udp://.")
-			os.Exit(commands.ErrBadCall)
+			os.Exit(cli.ErrBadCall)
 		}
 
 		duration, err := time.ParseDuration(attachFlags.searchTimeout)
@@ -115,7 +115,7 @@ func runAttachCommand(cmd *cobra.Command, args []string) {
 		board := findBoardFunc(pm, monitor, deviceURI)
 		if board == nil {
 			formatter.PrintErrorMessage("No supported board has been found at " + deviceURI.String() + ", try either install new cores or check your board URI.")
-			os.Exit(commands.ErrGeneric)
+			os.Exit(cli.ErrGeneric)
 		}
 		formatter.Print("Board found: " + board.Name())
 
@@ -152,7 +152,7 @@ func findSerialConnectedBoard(pm *packagemanager.PackageManager, monitor *discov
 
 	boards := pm.FindBoardsWithVidPid(serialDevice.VendorID, serialDevice.ProductID)
 	if len(boards) == 0 {
-		os.Exit(commands.ErrGeneric)
+		os.Exit(cli.ErrGeneric)
 	}
 
 	return boards[0]

cli/board/board.go

@@ -0,0 +1,41 @@
+/*
+ * This file is part of arduino-cli.
+ *
+ * Copyright 2018 ARDUINO SA (http://www.arduino.cc/)
+ *
+ * This software is released under the GNU General Public License version 3,
+ * which covers the main part of arduino-cli.
+ * The terms of this license can be found at:
+ * https://www.gnu.org/licenses/gpl-3.0.en.html
+ *
+ * You can be released from the requirements of the above licenses by purchasing
+ * a commercial license. Buying such a license is mandatory if you want to modify or
+ * otherwise use the software for commercial activities involving the Arduino
+ * software without disclosing the source code of your own applications. To purchase
+ * a commercial license, send an email to license@arduino.cc.
+ */
+
+package board
+
+import (
+	"github.com/arduino/arduino-cli/cli"
+	"github.com/spf13/cobra"
+)
+
+// InitCommand prepares the command.
+func InitCommand() *cobra.Command {
+	boardCommand := &cobra.Command{
+		Use:   "board",
+		Short: "Arduino board commands.",
+		Long:  "Arduino board commands.",
+		Example: "  # Lists all connected boards.\n" +
+			"  " + cli.AppName + " board list\n\n" +
+			"  # Attaches a sketch to a board.\n" +
+			"  " + cli.AppName + " board attach serial:///dev/tty/ACM0 mySketch",
+	}
+	boardCommand.AddCommand(initAttachCommand())
+	boardCommand.AddCommand(initDetailsCommand())
+	boardCommand.AddCommand(initListCommand())
+	boardCommand.AddCommand(initListAllCommand())
+	return boardCommand
+}

cli/board/details.go

@@ -0,0 +1,80 @@
+/*
+ * This file is part of arduino-cli.
+ *
+ * Copyright 2018 ARDUINO SA (http://www.arduino.cc/)
+ *
+ * This software is released under the GNU General Public License version 3,
+ * which covers the main part of arduino-cli.
+ * The terms of this license can be found at:
+ * https://www.gnu.org/licenses/gpl-3.0.en.html
+ *
+ * You can be released from the requirements of the above licenses by purchasing
+ * a commercial license. Buying such a license is mandatory if you want to modify or
+ * otherwise use the software for commercial activities involving the Arduino
+ * software without disclosing the source code of your own applications. To purchase
+ * a commercial license, send an email to license@arduino.cc.
+ */
+
+package board
+
+import (
+	"fmt"
+
+	"github.com/arduino/arduino-cli/cli"
+	b "github.com/arduino/arduino-cli/commands/board"
+	"github.com/arduino/arduino-cli/output"
+	"github.com/spf13/cobra"
+)
+
+func initDetailsCommand() *cobra.Command {
+	detailsCommand := &cobra.Command{
+		Use:     "details <FQBN>",
+		Short:   "Print details about a board.",
+		Long:    "Show information about a board, in particular if the board has options to be specified in the FQBN.",
+		Example: "  " + cli.AppName + " board details arduino:avr:nano",
+		Args:    cobra.ExactArgs(1),
+		Run:     runDetailsCommand,
+	}
+	return detailsCommand
+}
+
+func runDetailsCommand(cmd *cobra.Command, args []string) {
+	pm := cli.InitPackageManager()
+	res := b.Details(pm, &b.DetailsReq{Fqbn: args[0]})
+
+	if !cli.OutputJSON(res) {
+		outputDetailsResp(res)
+	}
+}
+
+func outputDetailsResp(details *b.DetailsResp) {
+	table := output.NewTable()
+	table.SetColumnWidthMode(1, output.Average)
+	table.AddRow("Board name:", details.Name)
+	for i, tool := range details.RequiredTools {
+		head := ""
+		if i == 0 {
+			table.AddRow()
+			head = "Required tools:"
+		}
+		table.AddRow(head, tool.Packager+":"+tool.Name, "", tool.Version)
+	}
+	for _, option := range details.ConfigOptions {
+		table.AddRow()
+		table.AddRow("Option:",
+			option.OptionLabel,
+			"", option.Option)
+		for _, value := range option.Values {
+			if value.Selected {
+				table.AddRow("",
+					output.Green(value.ValueLabel),
+					output.Green("✔"), output.Green(option.Option+"="+value.Value))
+			} else {
+				table.AddRow("",
+					value.ValueLabel,
+					"", option.Option+"="+value.Value)
+			}
+		}
+	}
+	fmt.Print(table.Render())
+}

commands/board/list.go renamed to cli/board/list.go

@@ -22,10 +22,10 @@ import (
 	"time"
 
 	"github.com/arduino/arduino-cli/arduino/cores/packagemanager"
-	"github.com/arduino/arduino-cli/commands"
+	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/common/formatter"
 	"github.com/arduino/arduino-cli/common/formatter/output"
-	"github.com/arduino/board-discovery"
+	discovery "github.com/arduino/board-discovery"
 	"github.com/codeclysm/cc"
 	"github.com/spf13/cobra"
 )
@@ -35,7 +35,7 @@ func initListCommand() *cobra.Command {
 		Use:     "list",
 		Short:   "List connected boards.",
 		Long:    "Detects and displays a list of connected boards to the current computer.",
-		Example: "  " + commands.AppName + " board list --timeout 10s",
+		Example: "  " + cli.AppName + " board list --timeout 10s",
 		Args:    cobra.NoArgs,
 		Run:     runListCommand,
 	}
@@ -52,7 +52,7 @@ var listFlags struct {
 // runListCommand detects and lists the connected arduino boards
 // (either via serial or network ports).
 func runListCommand(cmd *cobra.Command, args []string) {
-	pm := commands.InitPackageManager()
+	pm := cli.InitPackageManager()
 
 	monitor := discovery.New(time.Millisecond)
 	monitor.Start()

commands/board/listall.go renamed to cli/board/listall.go

@@ -21,7 +21,7 @@ import (
 	"sort"
 	"strings"
 
-	"github.com/arduino/arduino-cli/commands"
+	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/common/formatter"
 	"github.com/arduino/arduino-cli/common/formatter/output"
 	"github.com/spf13/cobra"
@@ -35,8 +35,8 @@ func initListAllCommand() *cobra.Command {
 			"List all boards that have the support platform installed. You can search\n" +
 			"for a specific board if you specify the board name",
 		Example: "" +
-			"  " + commands.AppName + " board listall\n" +
-			"  " + commands.AppName + " board listall zero",
+			"  " + cli.AppName + " board listall\n" +
+			"  " + cli.AppName + " board listall zero",
 		Args: cobra.ArbitraryArgs,
 		Run:  runListAllCommand,
 	}
@@ -45,7 +45,7 @@ func initListAllCommand() *cobra.Command {
 
 // runListAllCommand list all installed boards
 func runListAllCommand(cmd *cobra.Command, args []string) {
-	pm := commands.InitPackageManager()
+	pm := cli.InitPackageManager()
 
 	match := func(name string) bool {
 		name = strings.ToLower(name)