Skip to content

fix: handler HEAD calls in sse routes #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2025
Merged

fix: handler HEAD calls in sse routes #96

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
022f1c1
fix: handler HEAD calls in sse routes
lucarin91 Nov 20, 2025
5c25409
fix typo
lucarin91 Nov 21, 2025
0f9969c
make hotfix instead
lucarin91 Nov 21, 2025
2b5fe26
revert other sse endpoints
lucarin91 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo
  • Loading branch information
@lucarin91
lucarin91 committed Nov 21, 2025
commit 5c25409e51d124b22b51efafaac31ffa309b2053
2 changes: 1 addition & 1 deletion internal/api/handlers/app_logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func HandleAppLogs(
Follow: follow,
}

// Handle HEAD requests with erly return
// Handle HEAD requests with early return
if r.Method == http.MethodHead {
render.EncodeResponse(w, http.StatusOK, nil)
return
Expand Down
2 changes: 1 addition & 1 deletion internal/api/handlers/app_status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ func HandlerAppStatus(
cfg config.Configuration,
) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
// Handle HEAD requests with erly return
// Handle HEAD requests with early return
if r.Method == http.MethodHead {
render.EncodeResponse(w, http.StatusOK, nil)
return
Expand Down
2 changes: 1 addition & 1 deletion internal/api/handlers/system_resources.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (

func HandleSystemResources() http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
// Handle HEAD requests with erly return
// Handle HEAD requests with early return
if r.Method == http.MethodHead {
render.EncodeResponse(w, http.StatusOK, nil)
return
Expand Down
2 changes: 1 addition & 1 deletion internal/api/handlers/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func HandleUpdateApply(updater *update.Manager) http.HandlerFunc {

func HandleUpdateEvents(updater *update.Manager) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
// Handle HEAD requests with erly return
// Handle HEAD requests with early return
if r.Method == http.MethodHead {
render.EncodeResponse(w, http.StatusOK, nil)
return
Expand Down