Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
4df8f58
fix: improve error logging message in HandleBrickCreate function
dido18 Nov 12, 2025
650906d
test: rename TestBrickCreate to TestBrickCreateFromAppExample and upd…
dido18 Nov 12, 2025
59a73d2
fix: log a warning for missing mandatory variables in BrickCreate and…
dido18 Nov 12, 2025
18a0030
revert some changes
dido18 Nov 12, 2025
a8c8314
fix: update test cases for BrickCreate to improve clarity and logging
dido18 Nov 12, 2025
289e6af
fix: correct typo in comment for BrickCreate function to enhance clarity
dido18 Nov 12, 2025
ad54d74
fix: improve warning message for missing mandatory variables in Brick…
dido18 Nov 12, 2025
1e8e541
feat: add validation for app descriptors and corresponding test cases
dido18 Nov 13, 2025
58a4227
fix: correct expected error message for missing required variable in …
dido18 Nov 14, 2025
7878a2c
refactor: rename validation functions and update test cases for clari…
dido18 Nov 14, 2025
ef6c2de
fix: rename variable for clarity and validate app descriptor in Handl…
dido18 Nov 14, 2025
84f1256
fix: update error code to BadRequestErr in HandleAppStart and add cor…
dido18 Nov 14, 2025
9bc05ac
refactor: consolidate brick validation into AppDescriptor and update …
dido18 Nov 14, 2025
05f12bf
fix: ensure bricks index is not nil and capture error from ValidateBr…
dido18 Nov 14, 2025
70e1dbb
test: add YAML test cases for app descriptor validation with empty an…
dido18 Nov 14, 2025
38b49bc
test: add test case for validation of non-existing variable in app de…
dido18 Nov 14, 2025
3708460
fix: enhance brick validation to collect all errors and add new test …
dido18 Nov 14, 2025
d8028b6
fix: update ValidateBricks to return all validation errors as a slice…
dido18 Nov 14, 2025
6a17436
fix: update error handling in ValidateBricks to yield all validation …
dido18 Nov 14, 2025
c7a2e55
fix: refactor ValidateBricks to return a single error and update rela…
dido18 Nov 17, 2025
5742d45
test: add dummy app configuration and main.py for brick creation tests
dido18 Nov 17, 2025
1b18b36
fix: add logging for missing required variables in BrickCreate function
dido18 Nov 17, 2025
36319aa
chore: remove unused app.golden.yaml test data file
dido18 Nov 17, 2025
d9992fe
fix: clean up app.yaml by removing unused variables section
dido18 Nov 17, 2025
89bb0b9
refactor: move ValidateBricks function to a new file and update refer…
dido18 Nov 17, 2025
8acb1cc
refactor: update app type references from appspecification to app
dido18 Nov 17, 2025
4b525b3
FIX
dido18 Nov 17, 2025
7a9bdf2
refactor: log a warning for undeclared variables in brick configuration
dido18 Nov 17, 2025
7f935b9
Update internal/orchestrator/app/validator.go
dido18 Nov 17, 2025
1661442
refactor: rename variable for clarity in ValidateBricks function
dido18 Nov 17, 2025
2ccabd8
refactor: improve error handling and logging in validation functions
dido18 Nov 19, 2025
def6889
refactor: update test cases to use YAML content instead of filenames …
dido18 Nov 19, 2025
7a8ad44
refactor: remove obsolete YAML test files and clean up validator tests
dido18 Nov 19, 2025
ee2db2d
refactor: remove redundant brick validation from app restart process
dido18 Nov 19, 2025
c264066
refactor: improve error messages for brick update and validation proc…
dido18 Nov 19, 2025
98a2ae1
fix: correct typo in error message for required brick variable
dido18 Nov 19, 2025
18b6daf
refactor: improve error messages and update brick handling in service…
dido18 Nov 19, 2025
95728f2
refactor: update brick handling and improve test coverage for variabl…
dido18 Nov 19, 2025
d183dae
fix: correct typo in TODO comment for variable handling in tests
dido18 Nov 20, 2025
e1da66c
fix: remove hardcoded VERSION variable from build task in Taskfile
dido18 Nov 20, 2025
02df117
Update internal/orchestrator/bricks/bricks_test.go
dido18 Nov 20, 2025
37a4cf4
Add comprehensive AI model support documentation for AppLab
dido18 Nov 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: correct typo in error message for required brick variable
  • Loading branch information
dido18 committed Nov 19, 2025
commit 98a2ae15b8afa0de7253b754b8b471726fab9a66
2 changes: 1 addition & 1 deletion internal/orchestrator/bricks/bricks.go
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ func (s *Service) BrickCreate(
return fmt.Errorf("variable %q does not exist on brick %q", name, brick.ID)
}
if value.IsRequired() && reqValue == "" {
return fmt.Errorf("requried variable %q cannot be empty", name)
return fmt.Errorf("required variable %q cannot be empty", name)
}
}

Expand Down
Loading