-
Notifications
You must be signed in to change notification settings - Fork 4
fix(api): allow missing required variable when a brick is added + app validation #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dido18
wants to merge
19
commits into
main
Choose a base branch
from
fix-add-brick
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+247
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate test data feat: add AppFromExample configuration and Python main file for testing
… update test cases
…Create and update test case descriptions
…app descriptor test
…ty and consistency
…responding constant
…d omitted variables
…cases for validation scenarios
… and adjust related tests
…errors instead of the first one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #68
When a brick with required variables is added to an app created from scratch the operation fails.
This is because the FE (appLab) does not pass the required variables when the
PUT /v1/apps/{appID}/bricks/{brickID}is called.For example, the brick
arduino:arduino_cloudhas theARDUINO_DEVICE_IDandARDUINO_SECRETrequired.When it is added to a scratch app, it fails silently.
Additionally, the issue does not occur when an app with a brick already added is cloned.
This is because when an app is cloned the code does not check the required variable.
Change description
The following changes are
app.yamlis performed. Anapp.yamlis invalid in the following cases:Example:
Given the following
app-yaml, where the requiredARDUINO_SECRETvariable ofarduino:arduino_cloudis missing:When an app is started
When an app is restarted
Additional Notes
Reviewer checklist
main.