chore: internalize libraries not used externally

Author: lucarin91

cmd/arduino-app-cli/app/list.go

@@ -12,7 +12,7 @@ import (
 	"github.com/arduino/arduino-app-cli/cmd/feedback"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/config"
-	"github.com/arduino/arduino-app-cli/pkg/tablestyle"
+	"github.com/arduino/arduino-app-cli/internal/tablestyle"
 )
 
 func newListCmd(cfg config.Configuration) *cobra.Command {

cmd/arduino-app-cli/board/board.go

@@ -4,21 +4,17 @@ import (
 	"context"
 	"fmt"
 	"os"
-	"path"
 	"strconv"
 
 	"github.com/spf13/cobra"
 	"golang.org/x/term"
 
 	"github.com/arduino/arduino-app-cli/cmd/feedback"
-	"github.com/arduino/arduino-app-cli/pkg/appsync"
 	"github.com/arduino/arduino-app-cli/pkg/board"
 	"github.com/arduino/arduino-app-cli/pkg/board/remote"
 	"github.com/arduino/arduino-app-cli/pkg/board/remote/adb"
 )
 
-const boardHomePath = "/home/arduino"
-
 type contextKey string
 
 const remoteConnKey contextKey = "remoteConn"
@@ -61,9 +57,6 @@ func NewBoardCmd() *cobra.Command {
 	fsCmd.PersistentFlags().StringVarP(&fqbn, "fqbn", "b", "arduino:zephyr:unoq", "fqbn of the board")
 	fsCmd.PersistentFlags().StringVar(&host, "host", "", "ADB host address")
 
-	fsCmd.AddCommand(newPushCmd())
-	fsCmd.AddCommand(newPullCmd())
-	fsCmd.AddCommand(newSyncAppCmd())
 	fsCmd.AddCommand(newBoardListCmd())
 	fsCmd.AddCommand(newBoardSetName())
 	fsCmd.AddCommand(newSetPasswordCmd())
@@ -78,44 +71,6 @@ func NewBoardCmd() *cobra.Command {
 	return fsCmd
 }
 
-func newSyncAppCmd() *cobra.Command {
-	syncAppCmd := &cobra.Command{
-		Use:   "enable-sync <path>",
-		Short: "Enable sync of an path from the board",
-		Args:  cobra.ExactArgs(1),
-		RunE: func(cmd *cobra.Command, args []string) error {
-			conn := cmd.Context().Value(remoteConnKey).(remote.RemoteConn)
-
-			remote := path.Join(boardHomePath, args[0])
-
-			s, err := appsync.New(conn)
-			if err != nil {
-				return fmt.Errorf("failed to create apps sync: %w", err)
-			}
-			defer s.Close()
-			s.OnPull = func(name, path string) {
-				feedback.Printf(" ⬆️ Pulled app %q to folder %q", name, path)
-			}
-			s.OnPush = func(name string) {
-				feedback.Printf(" ⬇️ Pushed app %q to the board", name)
-			}
-
-			tmp, err := s.EnableSyncApp(remote)
-			if err != nil {
-				return fmt.Errorf("failed to enable sync for app %q: %w", remote, err)
-			}
-
-			feedback.Printf("Enable sync of %q at %q", remote, tmp)
-
-			<-cmd.Context().Done()
-			_ = s.DisableSyncApp(remote)
-			return nil
-		},
-	}
-
-	return syncAppCmd
-}
-
 func newBoardListCmd() *cobra.Command {
 	listCmd := &cobra.Command{
 		Use:   "list",

cmd/arduino-app-cli/board/pull.go

@@ -7,7 +7,7 @@ import (
 	"github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/internal/servicelocator"
 	"github.com/arduino/arduino-app-cli/cmd/feedback"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/bricks"
-	"github.com/arduino/arduino-app-cli/pkg/tablestyle"
+	"github.com/arduino/arduino-app-cli/internal/tablestyle"
 )
 
 func newBricksListCmd() *cobra.Command {

cmd/arduino-app-cli/board/push.go

@@ -7,17 +7,17 @@ import (
 	"net/http"
 	"time"
 
+	"github.com/jub0bs/cors"
+	"github.com/spf13/cobra"
+
 	"github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/internal/servicelocator"
 	"github.com/arduino/arduino-app-cli/internal/api"
+	"github.com/arduino/arduino-app-cli/internal/httprecover"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/config"
 	"github.com/arduino/arduino-app-cli/internal/update"
 	"github.com/arduino/arduino-app-cli/internal/update/apt"
 	"github.com/arduino/arduino-app-cli/internal/update/arduino"
-	"github.com/arduino/arduino-app-cli/pkg/httprecover"
-
-	"github.com/jub0bs/cors"
-	"github.com/spf13/cobra"
 )
 
 func NewDaemonCmd(cfg config.Configuration, version string) *cobra.Command {

cmd/arduino-app-cli/brick/list.go

@@ -10,14 +10,14 @@ import (
 
 	"github.com/arduino/arduino-app-cli/cmd/arduino-app-cli/internal/servicelocator"
 	"github.com/arduino/arduino-app-cli/cmd/feedback"
+	"github.com/arduino/arduino-app-cli/internal/helpers"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/config"
 	"github.com/arduino/arduino-app-cli/internal/update"
 	"github.com/arduino/arduino-app-cli/internal/update/apt"
 	"github.com/arduino/arduino-app-cli/internal/update/arduino"
 	"github.com/arduino/arduino-app-cli/pkg/board"
 	"github.com/arduino/arduino-app-cli/pkg/board/remote/local"
-	"github.com/arduino/arduino-app-cli/pkg/x"
 )
 
 func NewSystemCmd(cfg config.Configuration) *cobra.Command {
@@ -151,7 +151,7 @@ func newCleanUpCmd(cfg config.Configuration, docker command.Cli) *cobra.Command
 				feedback.Print("  - 1 running app")
 			}
 			feedback.Printf("  - %d containers", result.ContainersRemoved)
-			feedback.Printf("  - %d images (%v)", result.ImagesRemoved, x.ToHumanMiB(result.SpaceFreed))
+			feedback.Printf("  - %d images (%v)", result.ImagesRemoved, helpers.ToHumanMiB(result.SpaceFreed))
 			return nil
 		},
 	}

cmd/arduino-app-cli/daemon/daemon.go

@@ -28,7 +28,6 @@ require (
 	github.com/docker/compose/v2 v2.38.3-0.20250716153459-17ba6c7188fe
 	github.com/docker/docker v28.3.2+incompatible
 	github.com/fatih/color v1.18.0
-	github.com/fsnotify/fsnotify v1.9.0
 	github.com/goccy/go-yaml v1.18.0
 	github.com/gofrs/flock v0.12.1
 	github.com/google/go-cmp v0.7.0
@@ -120,6 +119,7 @@ require (
 	github.com/emirpasic/gods v1.18.1 // indirect
 	github.com/felixge/httpsnoop v1.0.4 // indirect
 	github.com/fsnotify/fsevents v0.2.0 // indirect
+	github.com/fsnotify/fsnotify v1.9.0 // indirect
 	github.com/fvbommel/sortorder v1.1.0 // indirect
 	github.com/fxamacker/cbor/v2 v2.7.0 // indirect
 	github.com/getkin/kin-openapi v0.132.0 // indirect

cmd/arduino-app-cli/system/system.go

@@ -8,7 +8,7 @@ import (
 	"github.com/arduino/arduino-app-cli/internal/api/models"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/modelsindex"
-	"github.com/arduino/arduino-app-cli/pkg/render"
+	"github.com/arduino/arduino-app-cli/internal/render"
 )
 
 func HandleModelsList(modelsIndex *modelsindex.ModelsIndex) http.HandlerFunc {

go.mod

@@ -11,7 +11,7 @@ import (
 	"github.com/arduino/arduino-app-cli/internal/orchestrator"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/app"
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/config"
-	"github.com/arduino/arduino-app-cli/pkg/render"
+	"github.com/arduino/arduino-app-cli/internal/render"
 
 	"github.com/docker/cli/cli/command"
 )