Implement delete operation

Author: alessio-perugini

internal/api/api.go

@@ -69,5 +69,11 @@ func NewHTTPRouter(dockerClient *dockerClient.Client) http.Handler {
 		}
 	})
 
+	deletehandler := handlers.HandleAppDelete()
+	mux.HandleFunc("DELETE /v1/apps/{path...}", func(w http.ResponseWriter, r *http.Request) {
+		path := r.PathValue("path")
+		deletehandler(w, r, orchestrator.ID(path))
+	})
+
 	return mux
 }

internal/api/handlers/app_delete.go

@@ -0,0 +1,39 @@
+package handlers
+
+import (
+	"log/slog"
+	"net/http"
+
+	"github.com/arduino/arduino-app-cli/internal/orchestrator"
+	"github.com/arduino/arduino-app-cli/pkg/parser"
+	"github.com/arduino/arduino-app-cli/pkg/render"
+)
+
+func HandleAppDelete() HandlerAppFunc {
+	return func(w http.ResponseWriter, r *http.Request, id orchestrator.ID) {
+		if id == "" {
+			render.EncodeResponse(w, http.StatusPreconditionFailed, "id must be set")
+			return
+		}
+		appPath, err := id.ToPath()
+		if err != nil {
+			render.EncodeResponse(w, http.StatusPreconditionFailed, "invalid id")
+			return
+		}
+
+		app, err := parser.Load(appPath.String())
+		if err != nil {
+			slog.Error("Unable to parse the app.yaml", slog.String("error", err.Error()), slog.String("path", string(id)))
+			render.EncodeResponse(w, http.StatusInternalServerError, "unable to find the app")
+			return
+		}
+
+		err = orchestrator.DeleteApp(r.Context(), app)
+		if err != nil {
+			slog.Error("Unable to delete the app", slog.String("error", err.Error()))
+			render.EncodeResponse(w, http.StatusInternalServerError, "unable to delete the app")
+			return
+		}
+		render.EncodeResponse(w, http.StatusOK, nil)
+	}
+}

internal/orchestrator/orchestrator.go

@@ -185,16 +185,19 @@ func StopApp(ctx context.Context, app parser.App) iter.Seq[StreamMessage] {
 				return
 			}
 			mainCompose := provisioningStateDir.Join("app-compose.yaml")
-			process, err := paths.NewProcess(nil, "docker", "compose", "-f", mainCompose.String(), "stop")
-			if err != nil {
-				yield(StreamMessage{error: err})
-				return
-			}
-			process.RedirectStderrTo(callbackWriter)
-			process.RedirectStdoutTo(callbackWriter)
-			if err := process.RunWithinContext(ctx); err != nil {
-				yield(StreamMessage{error: err})
-				return
+			// In case the app was never started
+			if mainCompose.Exist() {
+				process, err := paths.NewProcess(nil, "docker", "compose", "-f", mainCompose.String(), "stop")
+				if err != nil {
+					yield(StreamMessage{error: err})
+					return
+				}
+				process.RedirectStderrTo(callbackWriter)
+				process.RedirectStdoutTo(callbackWriter)
+				if err := process.RunWithinContext(ctx); err != nil {
+					yield(StreamMessage{error: err})
+					return
+				}
 			}
 		}
 		_ = yield(StreamMessage{progress: &Progress{Name: "", Progress: 100.0}})
@@ -479,6 +482,15 @@ func CloneApp(ctx context.Context, req CloneAppRequest) (response CloneAppRespon
 	return CloneAppResponse{ID: id}, nil
 }
 
+func DeleteApp(ctx context.Context, app parser.App) error {
+	for msg := range StopApp(ctx, app) {
+		if msg.error != nil {
+			return fmt.Errorf("failed to stop app: %w", msg.error)
+		}
+	}
+	return app.FullPath.RemoveAll()
+}
+
 func getCurrentUser() string {
 	// MacOS and Windows uses a VM so we don't need to map the user.
 	if runtime.GOOS == "darwin" || runtime.GOOS == "windows" {