feat: update check internet connectivity and run checks in parallel

Author: Xayton

go.mod

@@ -52,6 +52,7 @@ require (
 	go.bug.st/f v0.4.0
 	go.bug.st/serial v1.6.4
 	golang.org/x/crypto v0.41.0
+	golang.org/x/sync v0.17.0
 	golang.org/x/term v0.34.0
 	golang.org/x/text v0.29.0
 )
@@ -272,7 +273,6 @@ require (
 	golang.org/x/mod v0.27.0 // indirect
 	golang.org/x/net v0.43.0 // indirect
 	golang.org/x/oauth2 v0.30.0 // indirect
-	golang.org/x/sync v0.17.0 // indirect
 	golang.org/x/sys v0.36.0 // indirect
 	golang.org/x/time v0.11.0 // indirect
 	golang.org/x/tools v0.36.0 // indirect

internal/update/update.go

@@ -5,8 +5,12 @@ import (
 	"errors"
 	"fmt"
 	"log/slog"
+	"net/http"
 	"strings"
 	"sync"
+	"time"
+
+	"golang.org/x/sync/errgroup"
 )
 
 var ErrOperationAlreadyInProgress = errors.New("an operation is already in progress")
@@ -56,15 +60,42 @@ func (m *Manager) ListUpgradablePackages(ctx context.Context, matcher func(Upgra
 	}
 	defer m.lock.Unlock()
 
-	arduinoPkgs, err := m.arduinoPlatformUpdateService.ListUpgradablePackages(ctx, matcher)
-	if err != nil {
-		return nil, err
+	// Make sure to be connected to the internet, before checking for updates.
+	// This is needed because the checks below work also when offline (using cached data).
+	if !isConnected() {
+		return nil, errors.New("no internet connectivity")
 	}
 
-	debPkgs, err := m.debUpdateService.ListUpgradablePackages(ctx, matcher)
-	if err != nil {
+	// Get the list of upgradable packages from two sources (deb and platform) in parallel.
+	g, ctx := errgroup.WithContext(ctx)
+	var (
+		debPkgs     []UpgradablePackage
+		arduinoPkgs []UpgradablePackage
+	)
+
+	g.Go(func() error {
+		pkgs, err := m.debUpdateService.ListUpgradablePackages(ctx, matcher)
+		if err != nil {
+			return err
+		}
+		debPkgs = pkgs
+		return nil
+	})
+
+	g.Go(func() error {
+		pkgs, err := m.arduinoPlatformUpdateService.ListUpgradablePackages(ctx, matcher)
+		if err != nil {
+			return err
+		}
+		arduinoPkgs = pkgs
+		return nil
+	})
+
+	// Wait for all the checks to complete (or any to fail).
+	if err := g.Wait(); err != nil {
 		return nil, err
 	}
+
 	return append(arduinoPkgs, debPkgs...), nil
 }
 
@@ -161,3 +192,19 @@ func (b *Manager) broadcast(event Event) {
 		}
 	}
 }
+
+func isConnected() bool {
+	client := http.Client{
+		Timeout: 3 * time.Second,
+	}
+
+	// Just check that the connection can be estabilished.
+	// The HEAD method will not get the results and we are ignoring the HTTP status code.
+	resp, err := client.Head("https://downloads.arduino.cc/")
+	if err != nil {
+		return false
+	}
+	defer resp.Body.Close()
+
+	return true
+}