fix: update library index refresh interval to 10 minutes for improved performance

dido18 · dido18 · commit 4ef61452fcdb · 2025-11-07T12:10:00.000+01:00
diff --git a/internal/orchestrator/sketch_libs.go b/internal/orchestrator/sketch_libs.go
@@ -28,7 +28,7 @@ import (
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/app"
 )
 
-const indexUpdateInterval = 60 * time.Second
+const indexUpdateInterval = 10 * time.Minute
 
 func AddSketchLibrary(ctx context.Context, app app.ArduinoApp, libRef LibraryReleaseID, addDeps bool) ([]LibraryReleaseID, error) {
 	srv := commands.NewArduinoCoreServer()
@@ -54,7 +54,6 @@ func AddSketchLibrary(ctx context.Context, app app.ArduinoApp, libRef LibraryRel
 	})
 	req := &rpc.UpdateLibrariesIndexRequest{Instance: inst, UpdateIfOlderThanSecs: int64(indexUpdateInterval.Seconds())}
 	if err := srv.UpdateLibrariesIndex(req, stream); err != nil {
-		// TODO: only print a warn message instead of failing ? in order to avoid blocking the user to install the lib in case it is present into the local index
 		return []LibraryReleaseID{}, fmt.Errorf("error updating library index: %v", err)
 	}
 	slog.Debug("Library index update", "status", res().GetLibrariesIndex().GetStatus())

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ import (`
`28`	`28`	`"github.com/arduino/arduino-app-cli/internal/orchestrator/app"`
`29`	`29`	`)`
`30`	`30`
`31`		`-const indexUpdateInterval = 60 * time.Second`
	`31`	`+const indexUpdateInterval = 10 * time.Minute`
`32`	`32`
`33`	`33`	`func AddSketchLibrary(ctx context.Context, app app.ArduinoApp, libRef LibraryReleaseID, addDeps bool) ([]LibraryReleaseID, error) {`
`34`	`34`	`srv := commands.NewArduinoCoreServer()`
`@@ -54,7 +54,6 @@ func AddSketchLibrary(ctx context.Context, app app.ArduinoApp, libRef LibraryRel`
`54`	`54`	`})`
`55`	`55`	`req := &rpc.UpdateLibrariesIndexRequest{Instance: inst, UpdateIfOlderThanSecs: int64(indexUpdateInterval.Seconds())}`
`56`	`56`	`if err := srv.UpdateLibrariesIndex(req, stream); err != nil {`
`57`		`- // TODO: only print a warn message instead of failing ? in order to avoid blocking the user to install the lib in case it is present into the local index`
`58`	`57`	`return []LibraryReleaseID{}, fmt.Errorf("error updating library index: %v", err)`
`59`	`58`	`}`
`60`	`59`	`slog.Debug("Library index update", "status", res().GetLibrariesIndex().GetStatus())`