Improve app.yaml descriptor sanity checks

Author: cmaglie

internal/orchestrator/provision.go

@@ -24,14 +24,19 @@ func ProvisionApp(ctx context.Context, docker *dockerClient.Client, app parser.A
 		return fmt.Errorf("provisioning failed to pull base image: %w", err)
 	}
 
-	resp, err := docker.ContainerCreate(ctx, &container.Config{
-		Image:      pythonImage,
-		User:       getCurrentUser(),
-		Entrypoint: []string{"/run.sh", "provision"},
-	}, &container.HostConfig{
-		Binds:      []string{app.FullPath.String() + ":/app"},
-		AutoRemove: true,
-	}, nil, nil, generateContainerName(app.Name))
+	resp, err := docker.ContainerCreate(
+		ctx,
+		&container.Config{
+			Image:      pythonImage,
+			User:       getCurrentUser(),
+			Entrypoint: []string{"/run.sh", "provision"},
+		}, &container.HostConfig{
+			Binds:      []string{app.FullPath.String() + ":/app"},
+			AutoRemove: true,
+		},
+		nil,
+		nil,
+		generateContainerName(app.Name))
 	if err != nil {
 		return fmt.Errorf("provisiong failed to create container: %w", err)
 	}

pkg/parser/parser.go

@@ -76,6 +76,10 @@ func ParseDescriptorFile(file *paths.Path) (AppDescriptor, error) {
 		return AppDescriptor{}, fmt.Errorf("cannot decode descriptor: %w", err)
 	}
 
+	if descriptor.Name == "" {
+		return AppDescriptor{}, fmt.Errorf("application name is empty")
+	}
+
 	return descriptor, validate(descriptor)
 }