Merge remote-tracking branch 'origin/debugUpdates' into no_32k_crystal

Author: facchinm

cores/arduino/USB/PluggableUSBSerial.h

@@ -157,8 +157,8 @@ class USBSerial: public USBCDC, public ::mbed::Stream, public HardwareSerial {
     {
         USBCDC::lock();
 
-        if ((mptr != NULL) && (tptr != NULL)) {
-            rx[howManyCallbacks++] = ::mbed::Callback<void()>(mptr, tptr);
+        if ((mptr != NULL) && (tptr != NULL) && (_howManyCallbacks < sizeof(_rx)/sizeof(_rx[0]))) {
+            _rx[_howManyCallbacks++] = ::mbed::Callback<void()>(mptr, tptr);
         }
 
         USBCDC::unlock();
@@ -173,8 +173,8 @@ class USBSerial: public USBCDC, public ::mbed::Stream, public HardwareSerial {
     {
         USBCDC::lock();
 
-        if (fptr != NULL) {
-            rx[howManyCallbacks++] = ::mbed::Callback<void()>(fptr);
+        if ((fptr != NULL) && (_howManyCallbacks < sizeof(_rx)/sizeof(_rx[0]))) {
+            _rx[_howManyCallbacks++] = ::mbed::Callback<void()>(fptr);
         }
 
         USBCDC::unlock();
@@ -189,7 +189,9 @@ class USBSerial: public USBCDC, public ::mbed::Stream, public HardwareSerial {
     {
         USBCDC::lock();
 
-        rx[howManyCallbacks++] = cb;
+        if (_howManyCallbacks < sizeof(_rx)/sizeof(_rx[0])) {
+            _rx[_howManyCallbacks++] = cb;
+        }
 
         USBCDC::unlock();
     }
@@ -219,14 +221,17 @@ class USBSerial: public USBCDC, public ::mbed::Stream, public HardwareSerial {
     }
 
     int available(void) {
+        onInterrupt();
         return rx_buffer.available();
     }
 
     int peek(void) {
+        onInterrupt();
         return rx_buffer.peek();
     }
 
     int read(void) {
+        onInterrupt();
         return rx_buffer.read_char();
     }
 
@@ -273,9 +278,9 @@ class USBSerial: public USBCDC, public ::mbed::Stream, public HardwareSerial {
     }
 
 private:
-    ::mbed::Callback<void()> rx[MAX_CALLBACKS_ON_IRQ];
-    int howManyCallbacks = 0;
     void (*_settings_changed_callback)(int baud, int bits, int parity, int stop);
+    ::mbed::Callback<void()> _rx[MAX_CALLBACKS_ON_IRQ];
+    size_t _howManyCallbacks = 0;
 };
 }
 

cores/arduino/USB/USBSerial.cpp

@@ -95,14 +95,12 @@ void USBSerial::data_rx()
     USBCDC::assert_locked();
 
     //call a potential handler
-    int i = 0;
-    while (i < howManyCallbacks) {
-        if (rx[i]) {
-            rx[i].call();
+    for (size_t i = 0 ; i < _howManyCallbacks ; i++) {
+        if (_rx[i]) {
+            _rx[i].call();
         } else {
             break;
         }
-        i++;
     }
 }
 

libraries/KernelDebug/examples/KernelDebug/KernelDebug.ino

@@ -0,0 +1,16 @@
+/* This example demonstrates how to utilize the KernelDebug library which
+   allows kernel debugging of the Portenta H7 with GDB over a UART serial
+   connection.
+*/
+
+#include <KernelDebug.h>
+
+KernelDebug kernelDebug(SERIAL1_TX, SERIAL1_RX, USART1_IRQn, 230400, DEBUG_BREAK_IN_SETUP);
+
+void setup() {
+
+}
+
+void loop() {
+
+}

libraries/KernelDebug/library.properties

@@ -0,0 +1,9 @@
+name=KernelDebug
+version=1.0.0
+author=Adam Green <adamgreen@users.noreply.github.com>
+maintainer=Arduino <info@arduino.cc>
+sentence=The GDB compatible kernel debug monitor for Cortex-M devices.
+paragraph=KernelDebug is a debug monitor which allows the GNU debugger, GDB, to kernel debug applications running in both handler and thread modes using a full featured source level debugger with no extra hardware other than a UART serial connection.
+category=Communication
+url=
+architectures=mbed