This commit propagates changes in handling of anx7625 USB-C video

and VBUS switching to all the examples and libraries.
The anx7625_init function in anx7625.cpp driver has been empowered
by including the control of the gpios POWER_EN (video_on) and RESET_N (video_rst)
and also the VBUS switching according to anx7625 registers.
This has been done for the following reasons
- anx driver devel is not yet finished so it's easier when you have a single place to maintain
- timing is critical when dealing with anx and doing it in a single function means less confusion
for our users.

Author: MaxPayne86

libraries/LittleVGL/examples/Portenta_lvgl/Portenta_lvgl.ino

@@ -124,32 +124,19 @@ static void gpu_fill(lv_disp_drv_t * disp_drv, lv_color_t * dest_buf, lv_coord_t
   }
 }
 
-
 struct edid recognized_edid;
-mbed::DigitalOut video_on(PK_2);
-mbed::DigitalOut video_rst(PJ_3);
+
 void setup() {
   // put your setup code here, to run once:
-  delay(1000);
-  video_on = 1;
-  delay(10);
-  video_rst = 1;
-  delay(10);
   int ret = -1;
-  video_on = 0;
-  delay(10);
-  video_rst = 0;
-  delay(100);
-  while (ret < 0) {
-    video_on = 0;
-    delay(10);
-    video_rst = 0;
-    delay(100);
-    video_on = 1;
-    delay(100);
-    video_rst = 1;
-    ret = anx7625_init(0);
+
+  ret = anx7625_init(0);
+  if(ret < 0) {
+    printf("Cannot continue, anx7625 init failed.\n");
+    while(1);
   }
+
+  anx7625_wait_hpd_event(0);
   anx7625_dp_get_edid(0, &recognized_edid);
   anx7625_dp_start(0, &recognized_edid, EDID_MODE_720x480_60Hz);
   SDRAM.begin(getFramebufferEnd());

libraries/LittleVGL/porting.cpp

@@ -125,35 +125,19 @@ static void gpu_fill(lv_disp_drv_t * disp_drv, lv_color_t * dest_buf, lv_coord_t
   }
 }
 
-
 struct edid recognized_edid;
-mbed::DigitalOut video_on(PK_2);
-mbed::DigitalOut video_rst(PJ_3);
 
 void portenta_init_video() {
   // put your setup code here, to run once:
-  delay(1000);
-  video_on = 1;
-  delay(10);
-  video_rst = 1;
-  delay(10);
   int ret = -1;
-  video_on = 0;
-  delay(10);
-  video_rst = 0;
-  delay(100);
-
-  while (ret < 0) {
-    video_on = 0;
-    delay(10);
-    video_rst = 0;
-    delay(100);
-    video_on = 1;
-    delay(100);
-    video_rst = 1;
-    ret = anx7625_init(0);
+
+  ret = anx7625_init(0);
+  if(ret < 0) {
+    printf("Cannot continue, anx7625 init failed.\n");
+    while(1);
   }
 
+  anx7625_wait_hpd_event(0);
   anx7625_dp_get_edid(0, &recognized_edid);
   anx7625_dp_start(0, &recognized_edid, EDID_MODE_720x480_60Hz);
   SDRAM.begin(getFramebufferEnd());

libraries/Portenta_Video/anx7625.cpp

@@ -32,7 +32,9 @@
 #define ANXDEBUG(format, ...) \
 		printk(BIOS_DEBUG, "%s: " format, __func__, ##__VA_ARGS__)
 
-
+mbed::DigitalOut video_on(PK_2);
+mbed::DigitalOut video_rst(PJ_3);
+mbed::DigitalOut otg_on(PJ_6);
 mbed::I2C i2cx(I2C_SDA_INTERNAL , I2C_SCL_INTERNAL);
 
 int i2c_writeb(uint8_t bus, uint8_t saddr, uint8_t offset, uint8_t val) {
@@ -1314,7 +1316,25 @@ int anx7625_init(uint8_t bus)
 {
 	int retry_power_on = 3;
 
+	ANXINFO("OTG_ON = 1 -> VBUS OFF\n");
+	otg_on = 1;
+
+	mdelay(1000);
+	video_on = 1;
+	mdelay(10);
+	video_rst = 1;
+	mdelay(10);
+
+	video_on = 0;
+	mdelay(10);
+	video_rst = 0;
+	mdelay(100);
+
 	ANXINFO("Powering on anx7625...\n");
+	video_on = 1;
+	mdelay(100);
+	video_rst = 1;
+
 	while (--retry_power_on) {
 		if (anx7625_power_on_init(bus) == 0)
 			break;
@@ -1325,6 +1345,13 @@ int anx7625_init(uint8_t bus)
 	}
 	ANXINFO("Powering on anx7625 successfull.\n");
 	mdelay(200); // Wait for anx7625 to be stable
+
+	if(anx7625_is_power_provider(0)) {
+		ANXINFO("OTG_ON = 0 -> VBUS ON\n");
+		otg_on = 0;
+		mdelay(1000); // Wait for powered device to be stable
+	}
+
 	return 0;
 }
 

libraries/Portenta_Video/examples/Envie_video_coreboot/Envie_video_coreboot.ino

@@ -5,45 +5,17 @@
 
 struct edid recognized_edid;
 
-mbed::DigitalOut video_on(PK_2);
-mbed::DigitalOut video_rst(PJ_3);
-mbed::DigitalOut otg_on(PJ_6);
-
 void setup() {
   // put your setup code here, to run once:
-  printf("OTG_ON = 1 -> VBUS OFF\n");
-  otg_on = 1;
-
-  delay(1000);
-  video_on = 1;
-  delay(10);
-  video_rst = 1;
-  delay(10);
-
   int ret = -1;
-  video_on = 0;
-  delay(10);
-  video_rst = 0;
-  delay(100);
-
-  video_on = 1;
-  delay(100);
-  video_rst = 1;
 
   ret = anx7625_init(0);
   if(ret < 0) {
     printf("Cannot continue, anx7625 init failed.\n");
     while(1);
   }
 
-  if(anx7625_is_power_provider(0)) {
-    printf("OTG_ON = 0 -> VBUS ON\n");
-    otg_on = 0;
-    delay(1000); // Wait for device to be stable
-  }
-
   anx7625_wait_hpd_event(0);
-
   anx7625_dp_get_edid(0, &recognized_edid);
   anx7625_dp_start(0, &recognized_edid, EDID_MODE_640x480_60Hz);
 

libraries/doom/doomgeneric_arduino.cpp

@@ -91,9 +91,6 @@ static void addKeyToQueue(int pressed, unsigned char keyCode)
 
 struct edid recognized_edid;
 
-mbed::DigitalOut video_on(PK_2);
-mbed::DigitalOut video_rst(PJ_3);
-
 uint32_t LCD_X_Size = 0, LCD_Y_Size = 0;
 DMA2D_HandleTypeDef    DMA2D_Handle;
 
@@ -169,23 +166,13 @@ void DG_Init()
 {
   int ret = -1;
 
-  while (ret < 0) {
-    video_on = 0;
-    delay(10);
-    video_rst = 0;
-    delay(100);
-
-    video_on = 1;
-    delay(100);
-    video_rst = 1;
-
-    ret = anx7625_init(0);
-    printf("after init\n");
-
-    if (ret < 0) {
-      printf("anx7625_init returned %d\n", ret);
-    }
+  ret = anx7625_init(0);
+  if(ret < 0) {
+    printf("Cannot continue, anx7625 init failed.\n");
+    while(1);
   }
+
+  anx7625_wait_hpd_event(0);
   anx7625_dp_get_edid(0, &recognized_edid);
   //edid_set_framebuffer_bits_per_pixel(&recognized_edid, 16, 0);
   //set_display_mode(&recognized_edid, EDID_MODE_720x480_60Hz);