Fixed hot plug hdmi cable event handling. If cable is not present just sit and wait instead of resetting anx7625.

Author: MaxPayne86

libraries/Portenta_Video/anx7625.cpp

@@ -818,13 +818,13 @@ static int anx7625_hpd_change_detect(uint8_t bus)
 
 	ret = anx7625_reg_read(bus, RX_P0_ADDR, SYSTEM_STSTUS, &status);
 	if (ret < 0) {
-		ANXERROR("IO error: Failed to clear interrupt status.\n");
+		ANXERROR("IO error: Failed to read HPD_STATUS register.\n");
 		return ret;
 	}
 
 	if (status & HPD_STATUS) {
 		anx7625_start_dp_work(bus);
-		ANXINFO("HPD received 0x7e:0x45=%#x\n", status);
+		ANXINFO("HPD event received 0x7e:0x45=%#x\n", status);
 		return 1;
 	}
 	return 0;
@@ -1312,9 +1312,9 @@ int anx7625_dp_get_edid(uint8_t bus, struct edid *out)
 
 int anx7625_init(uint8_t bus)
 {
-	int retry_hpd_change = 500;
 	int retry_power_on = 3;
 
+	ANXINFO("Powering on anx7625...\n");
 	while (--retry_power_on) {
 		if (anx7625_power_on_init(bus) == 0)
 			break;
@@ -1323,16 +1323,18 @@ int anx7625_init(uint8_t bus)
 		ANXERROR("Failed to power on.\n");
 		return -1;
 	}
+	ANXINFO("Powering on anx7625 successfull.\n");
 
-	while (--retry_hpd_change) {
+	return 0;
+}
+
+void anx7625_wait_hpd_event(uint8_t bus)
+{
+	ANXINFO("Waiting for hdmi hot plug event...\n");
+	while (1) {
 		mdelay(10);
 		int detected = anx7625_hpd_change_detect(bus);
-		if (detected < 0)
-			return -1;
-		if (detected > 0)
-			return 0;
+		if (detected == 1)
+			break;
 	}
-
-	ANXERROR("Timed out to detect HPD change on bus %d.\n", bus);
-	return -1;
 }

libraries/Portenta_Video/anx7625.h

@@ -363,6 +363,7 @@ struct display_timing {
 int anx7625_dp_start(uint8_t bus, const struct edid *edid, enum edid_modes mode = EDID_MODE_AUTO);
 int anx7625_dp_get_edid(uint8_t bus, struct edid *out);
 int anx7625_init(uint8_t bus);
+void anx7625_wait_hpd_event(uint8_t bus);
 int stm32_dsi_config(uint8_t bus, struct edid *edid, struct display_timing *dt);
 void stm32_BriefDisplay(void);
 void stm32_LCD_Clear(uint32_t color);
@@ -374,4 +375,4 @@ uint32_t stm32_getYSize();
 uint32_t getFramebufferEnd();
 DMA2D_HandleTypeDef* stm32_get_DMA2D(void);
 
-#endif  /* __ANX7625_H__ */
+#endif  /* __ANX7625_H__ */

libraries/Portenta_Video/examples/Envie_video_coreboot/Envie_video_coreboot.ino

@@ -21,19 +21,19 @@ void setup() {
   delay(10);
   video_rst = 0;
   delay(100);
-  while (ret < 0) {
 
-    video_on = 0;
-    delay(10);
-    video_rst = 0;
-    delay(100);
-
-    video_on = 1;
-    delay(100);
-    video_rst = 1;
+  video_on = 1;
+  delay(100);
+  video_rst = 1;
 
-    ret = anx7625_init(0);
+  ret = anx7625_init(0);
+  if(ret < 0) {
+    printf("Cannot continue, anx7625 init failed.\n");
+    while(1);
   }
+
+  anx7625_wait_hpd_event(0);
+
   anx7625_dp_get_edid(0, &recognized_edid);
   anx7625_dp_start(0, &recognized_edid, EDID_MODE_640x480_60Hz);
 
@@ -47,10 +47,7 @@ void setup() {
 int i = 0;
 
 void loop() {
-  delay(1000);
-
-  i = random(0, 0xFFFFFF);
-  printf("now: %d\n", millis());
+  printf("Now: %d\n", millis());
 
   delay(1000);
 }