Skip to content

Change the colour of PREPROCESSOR words (Suggestion) #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ReeceM opened this issue Jul 8, 2015 · 5 comments
Closed

Change the colour of PREPROCESSOR words (Suggestion) #3480

ReeceM opened this issue Jul 8, 2015 · 5 comments
Assignees
Labels
Component: IDE user interface The Arduino IDE's user interface
Milestone

Comments

@ReeceM
Copy link

ReeceM commented Jul 8, 2015

I was wondering if it would be okay to change the colour of preprocessors to the way C++ or othe IDEs colour them eg.

#define xyz
#include <xyz.h>

I thought this would be better as it makes them more distinguishable from other things as the straight black colour to them just seems ugly and it looks like other code when it is mixed up around other variables(although you wouldn't have stuff clumped together):

2015-07-08 14_07_13-sketch_jul08a _ arduino 1 6 6 hourly build 2015_07_07 09_41

Compared to this:
2015-07-08 14_04_11-sketch_jul08a _ arduino 1 6 6 hourly build 2015_07_07 09_41

I edited the theme.xml PREPROCESSOR style token and put a new value in for fg, very simple though.

<style token="PREPROCESSOR" fg="9a4e00" bold="false"/>

A link to the color charts.

@ffissore
Copy link
Contributor

ffissore commented Jul 8, 2015

/cc @00alis

@ffissore ffissore added the Component: IDE user interface The Arduino IDE's user interface label Jul 8, 2015
@ffissore ffissore self-assigned this Jul 8, 2015
@00alis
Copy link
Contributor

00alis commented Jul 8, 2015

Good catch @ReeceM!

#define and #include should be green because they are part of the Structure category, as you can see in the Language Reference page https://www.arduino.cc/en/Reference/HomePage

We can make this change for the next release! Thanks for your feedback!

@ffissore ffissore added this to the Release 1.6.6 milestone Jul 8, 2015
@ffissore
Copy link
Contributor

ffissore commented Jul 8, 2015

Fixed. Fix will be available with next hourly build http://www.arduino.cc/en/Main/Software#hourly

@ReeceM
Copy link
Author

ReeceM commented Jul 8, 2015

Cool, I'm glad it was of use to point it out and help, its bothered me since I noticed it.

I did it brown as I liked the look N++ gives for C++ code style.

@00alis
Copy link
Contributor

00alis commented Jul 8, 2015

Thank you both!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: IDE user interface The Arduino IDE's user interface
Projects
None yet
Development

No branches or pull requests

3 participants