Fixed a crashed when user attempted to delete a tab of a not yet compiled sketch. Fixes #3913

Author: Federico Fissore

arduino-core/src/processing/app/SketchCode.java

@@ -26,8 +26,13 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
 import java.util.Arrays;
 import java.util.List;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
 
 import static processing.app.I18n.tr;
 
@@ -91,35 +96,39 @@ protected boolean fileReadOnly() {
   }
 
 
-  protected boolean deleteFile(File tempBuildFolder) {
+  protected boolean deleteFile(File tempBuildFolder) throws IOException {
     if (!file.delete()) {
       return false;
     }
 
-    if (!deleteCompiledFilesFrom(tempBuildFolder)) {
-      return false;
-    }
+    List<Path> tempBuildFolders = Stream.of(tempBuildFolder.toPath(), Paths.get(tempBuildFolder.getAbsolutePath(), "sketch"))
+      .filter(path -> Files.exists(path))
+      .collect(Collectors.toList());
 
-    if (!deleteCompiledFilesFrom(new File(tempBuildFolder, "sketch"))) {
-      return false;
+    for (Path folder : tempBuildFolders) {
+      if (!deleteCompiledFilesFrom(folder)) {
+        return false;
+      }
     }
 
     return true;
   }
 
-  private boolean deleteCompiledFilesFrom(File tempBuildFolder) {
-    File[] compiledFiles = tempBuildFolder.listFiles(pathname -> {
-      return pathname.getName().startsWith(getFileName());
-    });
-    for (File compiledFile : compiledFiles) {
-      if (!compiledFile.delete()) {
+  private boolean deleteCompiledFilesFrom(Path tempBuildFolder) throws IOException {
+    List<Path> compiledFiles = Files.list(tempBuildFolder)
+      .filter(pathname -> pathname.getFileName().toString().startsWith(getFileName()))
+      .collect(Collectors.toList());
+
+    for (Path compiledFile : compiledFiles) {
+      try {
+        Files.delete(compiledFile);
+      } catch (IOException e) {
         return false;
       }
     }
     return true;
   }
 
-
   protected boolean renameTo(File what) {
     boolean success = file.renameTo(what);
     if (success) {