simplify publish function

hmueller01 · hmueller01 · commit f0ffdd7991f3 · 2024-11-17T21:39:24.000+01:00
diff --git a/src/MqttClient.cpp b/src/MqttClient.cpp
@@ -272,11 +272,10 @@ int MqttClient::endMessage()
  */
 int MqttClient::publish(const char* topic, const char* payload, bool retain, uint8_t qos, bool dup) {
   int ret = beginMessage(topic, strlen_P(payload), retain, qos, dup);
-  if (!ret) {
-    return ret;
+  if (ret) {
+    print(payload);
+    ret = endMessage();
   }
-  print(payload);
-  ret = endMessage();
   return ret;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -272,11 +272,10 @@ int MqttClient::endMessage()`
`272`	`272`	`*/`
`273`	`273`	`int MqttClient::publish(const char* topic, const char* payload, bool retain, uint8_t qos, bool dup) {`
`274`	`274`	`int ret = beginMessage(topic, strlen_P(payload), retain, qos, dup);`
`275`		`- if (!ret) {`
`276`		`- return ret;`
	`275`	`+ if (ret) {`
	`276`	`+ print(payload);`
	`277`	`+ ret = endMessage();`
`277`	`278`	`}`
`278`		`- print(payload);`
`279`		`- ret = endMessage();`
`280`	`279`	`return ret;`
`281`	`280`	`}`
`282`	`281`