-
Notifications
You must be signed in to change notification settings - Fork 85
bin2ota Fix: Add missing colon #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request @Jorgetrujilloroman!
Since it is not related to the code defect addressed here, please open a dedicated issue about the lack of documentation/infrastructure for managing the package dependency of this script. |
|
Done, could fix the Module error by installing the crccheck module after install python pip on my ubuntu. Thank you very much. |
|
Hi @Jorgetrujilloroman Thanks for the fix. Something like the PR title should be fine. Thanks |
pennam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix is good, could you please reword the commit description as requested in the PR conversation?
Adding missing colon on line 29
pennam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hey @pennam I don't have rights to merge this PR, could you please do it? :) |
Now it looks like:
elif board == "NICLA_VISION":