Skip to content

Commit cff4527

Browse files
committed
support nsresolver in TraceConfig
1 parent ba76ac6 commit cff4527

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

examples/consumer/trace/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ import (
3131
func main() {
3232
namesrvs := []string{"127.0.0.1:9876"}
3333
traceCfg := &primitive.TraceConfig{
34-
Access: primitive.Local,
35-
NamesrvAddrs: namesrvs,
34+
Access: primitive.Local,
35+
Resolver: primitive.NewPassthroughResolver(namesrvs),
3636
}
3737

3838
c, _ := rocketmq.NewPushConsumer(

examples/producer/trace/main.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ import (
3131
func main() {
3232
namesrvs := []string{"127.0.0.1:9876"}
3333
traceCfg := &primitive.TraceConfig{
34-
Access: primitive.Local,
35-
NamesrvAddrs: namesrvs,
34+
Access: primitive.Local,
35+
Resolver: primitive.NewPassthroughResolver(namesrvs),
3636
}
3737

3838
p, _ := rocketmq.NewProducer(

internal/trace.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ func NewTraceDispatcher(traceCfg *primitive.TraceConfig) *traceDispatcher {
241241
t = TraceTopicPrefix + traceCfg.TraceTopic
242242
}
243243

244-
srvs, err := NewNamesrv(primitive.NewPassthroughResolver(traceCfg.NamesrvAddrs))
244+
srvs, err := NewNamesrv(traceCfg.Resolver)
245245
if err != nil {
246246
panic(errors.Wrap(err, "new Namesrv failed."))
247247
}
@@ -251,7 +251,6 @@ func NewTraceDispatcher(traceCfg *primitive.TraceConfig) *traceDispatcher {
251251

252252
cliOp := DefaultClientOptions()
253253
cliOp.GroupName = traceCfg.GroupName
254-
cliOp.NameServerAddrs = traceCfg.NamesrvAddrs
255254
cliOp.InstanceName = "INNER_TRACE_CLIENT_DEFAULT"
256255
cliOp.RetryTimes = 0
257256
cliOp.Namesrv = srvs

primitive/trace.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,6 @@ type TraceConfig struct {
2323
GroupName string
2424
Access AccessChannel
2525
NamesrvAddrs []string
26+
Resolver NsResolver
2627
Credentials // acl config for trace. omit if acl is closed on broker.
2728
}

0 commit comments

Comments
 (0)