From a18d8804a826b7723a1bbbc65f3271b9653fce71 Mon Sep 17 00:00:00 2001 From: Alan Agius <17563226+alan-agius4@users.noreply.github.com> Date: Thu, 14 Aug 2025 11:53:41 +0000 Subject: [PATCH] refactor: await `silentNpm` This is causing Windows CI to fail to the `silentNpm` being terminated. --- .../e2e/tests/mcp/registers-tools.ts | 24 ++++++++++--------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/tests/legacy-cli/e2e/tests/mcp/registers-tools.ts b/tests/legacy-cli/e2e/tests/mcp/registers-tools.ts index e2c9461d6a26..a1271b35b64c 100644 --- a/tests/legacy-cli/e2e/tests/mcp/registers-tools.ts +++ b/tests/legacy-cli/e2e/tests/mcp/registers-tools.ts @@ -29,19 +29,21 @@ export default async function () { ); // Ensure 'list_projects' is registered when inside an Angular workspace - const { stdout: stdoutInsideWorkspace } = await runInspector('--method', 'tools/list'); + try { + const { stdout: stdoutInsideWorkspace } = await runInspector('--method', 'tools/list'); - assert.match(stdoutInsideWorkspace, /"list_projects"/); - assert.match(stdoutInsideWorkspace, /"get_best_practices"/); - assert.match(stdoutInsideWorkspace, /"search_documentation"/); + assert.match(stdoutInsideWorkspace, /"list_projects"/); + assert.match(stdoutInsideWorkspace, /"get_best_practices"/); + assert.match(stdoutInsideWorkspace, /"search_documentation"/); - chdir('..'); + chdir('..'); - const { stdout: stdoutOutsideWorkspace } = await runInspector('--method', 'tools/list'); + const { stdout: stdoutOutsideWorkspace } = await runInspector('--method', 'tools/list'); - assert.doesNotMatch(stdoutOutsideWorkspace, /"list_projects"/); - assert.match(stdoutOutsideWorkspace, /"get_best_practices"/); - assert.match(stdoutInsideWorkspace, /"search_documentation"/); - - silentNpm('uninstall', '-g', MCP_INSPECTOR_PACKAGE_NAME); + assert.doesNotMatch(stdoutOutsideWorkspace, /"list_projects"/); + assert.match(stdoutOutsideWorkspace, /"get_best_practices"/); + assert.match(stdoutInsideWorkspace, /"search_documentation"/); + } finally { + await silentNpm('uninstall', '-g', MCP_INSPECTOR_PACKAGE_NAME); + } }